Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown style and diagram text alignment #24588

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix dropdown style and diagram text alignment #24588

merged 1 commit into from
Feb 18, 2025

Conversation

unidevel
Copy link
Contributor

@unidevel unidevel commented Feb 18, 2025 •
edited
Loading

Description

Fix several style issues from the dependency upgrade PR:

Motivation and Context

Impact

UI

Test Plan

Local testing

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 18, 2025
@unidevel unidevel marked this pull request as ready for review February 18, 2025 15:27
@unidevel unidevel requested review from yhwang and a team as code owners February 18, 2025 15:27
@unidevel unidevel requested a review from jaystarshot February 18, 2025 15:27
@unidevel unidevel mentioned this pull request Feb 18, 2025
Open
17 tasks
yhwang
yhwang approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes

@yhwang yhwang merged commit 9c4b683 into prestodb:master Feb 18, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhwang yhwang yhwang approved these changes

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unidevel @yhwang @prestodb-ci