[native] fix(iceberg): Date partition value parse issue

[nmahadevuni]

Description

Fixes #24371

Motivation and Context

Filter on date column fails in Iceberg since the value returned by Iceberg API is in daysSinceEpoch but we assume its in ISO format "YYYY-MM-DD" and try to convert it to daysSinceEpoch. Velox side changes are merged in facebookincubator/velox#12126

Impact

None.

Test Plan

Added tests in TestPrestoNativeIcebergGeneralQueries.java

Release Notes

== RELEASE NOTES ==

General Changes
* Fix Iceberg date column filtering

[nmahadevuni]

@aditi-pandit @majetideepak @Yuhta Can you please review this?

[aditi-pandit]

Thanks @nmahadevuni for these changes. Have 2 questions for you.

[aditi-pandit]

The current test returns all rows from the underlying table without actually demonstrating the filtering expected. Add rows with values < date('1994-01-01) to be skippped by the filter.

[aditi-pandit]

All the queries (both insertion and reading) use the date function in predicates. The date function actually transforms the string date value to integer days since epoch. The constant folding will evaluate this function before creating the partition filter. So I feel this issue happens irrespective of Iceberg.

Can you try queries without date function in the filter predicate ? What happens ?

[nmahadevuni]

That's how the date literals can be specified. I have removed the parenthesis to avoid the confusion. If we just specify the date string, then we get the varchar to date conversion error.

[nmahadevuni]

Thanks @aditi-pandit , I have addressed the comments.