-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add ConnectorDeleteTableHandle to support DELETEs
Changes to update finishDelete to new types Fixed Iceberg Delete as proof of concept. Fixed missing serialization changes. Kudu fix and checkstyle recombine iceberg tablehandle and deletetablehandle, fix serialization Documentation and add delete pagesink Fix implementation of delete pagesink delete extra comments/changes update KuduTableHandle remove comments and unused handle add kudu resolver for delete handle
- Loading branch information
1 parent
db0fe87
commit 399bba2
Showing
24 changed files
with
234 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
presto-main/src/main/java/com/facebook/presto/metadata/DeleteTableHandle.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.metadata; | ||
|
|
||
| import com.facebook.presto.spi.ConnectorDeleteTableHandle; | ||
| import com.facebook.presto.spi.ConnectorId; | ||
| import com.facebook.presto.spi.connector.ConnectorTransactionHandle; | ||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public final class DeleteTableHandle | ||
| { | ||
| private final ConnectorId connectorId; | ||
| private final ConnectorTransactionHandle transactionHandle; | ||
| private final ConnectorDeleteTableHandle connectorHandle; | ||
|
|
||
| @JsonCreator | ||
| public DeleteTableHandle( | ||
| @JsonProperty("connectorId") ConnectorId connectorId, | ||
| @JsonProperty("transactionHandle") ConnectorTransactionHandle transactionHandle, | ||
| @JsonProperty("connectorHandle") ConnectorDeleteTableHandle connectorHandle) | ||
| { | ||
| this.connectorId = requireNonNull(connectorId, "connectorId is null"); | ||
| this.transactionHandle = requireNonNull(transactionHandle, "transactionHandle is null"); | ||
| this.connectorHandle = requireNonNull(connectorHandle, "connectorHandle is null"); | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public ConnectorId getConnectorId() | ||
| { | ||
| return connectorId; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public ConnectorTransactionHandle getTransactionHandle() | ||
| { | ||
| return transactionHandle; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public ConnectorDeleteTableHandle getConnectorHandle() | ||
| { | ||
| return connectorHandle; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() | ||
| { | ||
| return Objects.hash(connectorId, transactionHandle, connectorHandle); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) | ||
| { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if (obj == null || getClass() != obj.getClass()) { | ||
| return false; | ||
| } | ||
| DeleteTableHandle o = (DeleteTableHandle) obj; | ||
| return Objects.equals(this.connectorId, o.connectorId) && | ||
| Objects.equals(this.transactionHandle, o.transactionHandle) && | ||
| Objects.equals(this.connectorHandle, o.connectorHandle); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() | ||
| { | ||
| return connectorId + ":" + connectorHandle; | ||
| } | ||
| } |
30 changes: 30 additions & 0 deletions
30
presto-main/src/main/java/com/facebook/presto/metadata/DeleteTableHandleJacksonModule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.metadata; | ||
|
|
||
| import com.facebook.presto.spi.ConnectorDeleteTableHandle; | ||
|
|
||
| import javax.inject.Inject; | ||
|
|
||
| public class DeleteTableHandleJacksonModule | ||
| extends AbstractTypedJacksonModule<ConnectorDeleteTableHandle> | ||
| { | ||
| @Inject | ||
| public DeleteTableHandleJacksonModule(HandleResolver handleResolver) | ||
| { | ||
| super(ConnectorDeleteTableHandle.class, | ||
| handleResolver::getId, | ||
| handleResolver::getDeleteTableHandleClass); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.