Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static site link #4

Open
alexj-lee opened this issue Jun 11, 2024 · 1 comment
Open

Static site link #4

alexj-lee opened this issue Jun 11, 2024 · 1 comment

Comments

@alexj-lee
Copy link

Thanks a lot for sharing this codebase. Cool paper--I am eager to see the specific data used in the paper when it is done being prepared.

I noticed the provided static site URL points to nowhere. I think this might be the correct link: https://prescient-design.github.io/lobster/

Also, I noticed that the script at src/lobster/cmdline/_train.py explicitly logs in to genentech.wandb.io in the wandb.login().

Would you be open to parameterizing the host in the src/lobster/hydra_config/logger/wandb.yaml file instead? It would make the repo marginally more usable to newcomers, although I understand if you prefer end-users implement their own train script.

@ncfrey
Copy link
Collaborator

ncfrey commented Jul 24, 2024

@alexj-lee Thanks for raising these issues! I will make that change - feel free to open a PR as well if you get to it before me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants