New Adapter: Adverxo #3677 #3705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AntoxaAntoxic, can You check my adapter because I have problem with AdverxoTest |
AntoxaAntoxic
requested changes
Feb 11, 2025
Comment on lines
+87
to
+98
| private String resolveEndpoint(ExtImpAdverxo extImpAdverxo) { | ||
| final String adUnitAsString = Optional.of(extImpAdverxo.getAdUnitId()) | ||
| .map(Object::toString) | ||
| .orElse(StringUtils.EMPTY); | ||
| final String authAsString = Optional.ofNullable(extImpAdverxo.getAuth()) | ||
| .map(Object::toString) | ||
| .orElse(StringUtils.EMPTY); | ||
|
|
||
| return endpointUrl | ||
| .replace(ADUNIT_MACROS_ENDPOINT, adUnitAsString) | ||
| .replace(AUTH_MACROS_ENDPOINT, authAsString); | ||
| } |
There was a problem hiding this comment.
HttpUtil.encodeUrl(StringUtils.defaultString(impExt.getEnv()))
private String resolveEndpoint(ExtImpAdverxo extImp) {
return endpointUrl
.replace(ADUNIT_MACROS_ENDPOINT, extImp.getAdUnitId() == null ? StringUtils.EMPTY : String.valueOf(extImp.getAdUnitId()))
.replace(AUTH_MACROS_ENDPOINT, HttpUtil.encodeUrl(StringUtils.defaultString(extImp.getAuth())));
}| public class ExtImpAdverxo { | ||
|
|
||
| @JsonProperty("adUnitId") | ||
| int adUnitId; |
There was a problem hiding this comment.
please use a non-primitive type
Comment on lines
+100
to
+121
| private Imp modifyImp(Imp imp, BidRequest request) { | ||
| final BigDecimal bidFloor = imp.getBidfloor(); | ||
| final String bidFloorCur = imp.getBidfloorcur(); | ||
|
|
||
| if (bidFloor != null && bidFloor.compareTo(BigDecimal.ZERO) > 0 | ||
| && StringUtils.isNotBlank(bidFloorCur) | ||
| && !StringUtils.equalsIgnoreCase(bidFloorCur, DEFAULT_BID_CURRENCY)) { | ||
|
|
||
| final BigDecimal convertedPrice = currencyConversionService.convertCurrency( | ||
| bidFloor, | ||
| request, | ||
| bidFloorCur, | ||
| DEFAULT_BID_CURRENCY | ||
| ); | ||
|
|
||
| return imp.toBuilder() | ||
| .bidfloor(convertedPrice) | ||
| .bidfloorcur(DEFAULT_BID_CURRENCY) | ||
| .build(); | ||
| } | ||
| return imp; | ||
| } |
There was a problem hiding this comment.
private Imp modifyImp(BidRequest bidRequest, Imp imp) {
final Price resolvedBidFloor = resolveBidFloor(imp, bidRequest);
return imp.toBuilder()
.bidfloor(resolvedBidFloor.getValue())
.bidfloorcur(resolvedBidFloor.getCurrency())
.build();
}
private Price resolveBidFloor(Imp imp, BidRequest bidRequest) {
final Price initialBidFloorPrice = Price.of(imp.getBidfloorcur(), imp.getBidfloor());
return BidderUtil.shouldConvertBidFloor(initialBidFloorPrice, DEFAULT_BID_CURRENCY)
? convertBidFloor(initialBidFloorPrice, bidRequest)
: initialBidFloorPrice;
}
private Price convertBidFloor(Price bidFloorPrice, BidRequest bidRequest) {
final BigDecimal convertedPrice = currencyConversionService.convertCurrency(
bidFloorPrice.getValue(),
bidRequest,
bidFloorPrice.getCurrency(),
DEFAULT_BID_CURRENCY);
return Price.of(DEFAULT_BID_CURRENCY, convertedPrice);
}| return imp; | ||
| } | ||
|
|
||
| private BidRequest createRequest(BidRequest originalRequest, Imp modifiedImp) { |
Comment on lines
+129
to
+140
| private HttpRequest<BidRequest> createHttpRequest(BidRequest outgoingRequest, | ||
| String endpoint, | ||
| String impId) { | ||
| return HttpRequest.<BidRequest>builder() | ||
| .method(HttpMethod.POST) | ||
| .uri(endpoint) | ||
| .headers(HttpUtil.headers()) | ||
| .body(mapper.encodeToBytes(outgoingRequest)) | ||
| .impIds(Collections.singleton(impId)) | ||
| .payload(outgoingRequest) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
use BidderUtil.defaultRequest instead
| final Imp modifiedImp = modifyImp(imp, request); | ||
| final BidRequest outgoingRequest = createRequest(request, modifiedImp); | ||
|
|
||
| requests.add(createHttpRequest(outgoingRequest, endpoint, imp.getId())); |
There was a problem hiding this comment.
a request per imp case is not covered in unit tests
| } | ||
|
|
||
| @Test | ||
| public void makeBidsShouldCorrectlyResolveBidTypes() throws JsonProcessingException { |
| .impid("123") | ||
| .mtype(1) | ||
| .adm("Price is ${AUCTION_PRICE}") | ||
| .nurl("nurl?price=${AUCTION_PRICE}") |
There was a problem hiding this comment.
nurl is not changed in Go
| @Test | ||
| public void makeBidsShouldHandleNativeAdmParsing() throws JsonProcessingException { | ||
| // Given | ||
| final String adm = "{\"native\": {\"key\": \"value\"}}"; |
There was a problem hiding this comment.
cover the case when a native adm can't be parsed
| .bid(List.of( | ||
| Bid.builder().impid("123").mtype(1).adm("bannerAdm").build(), | ||
| Bid.builder().impid("456").mtype(2).adm("videoAdm").build(), | ||
| Bid.builder().impid("789").mtype(4).adm("{\"native\":{\"assets\":[]}}").build())) |
There was a problem hiding this comment.
cover the case when the returned mtype is not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
#3677 (comment)