Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): #32: save chainIn in localstorage #64

Closed
wants to merge 1 commit into from

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Jun 26, 2024

Closes #32

Stores chainId in chrome extension storage on RPC change, so it doesn't require a request from the service worker later.

Decided to store chainId instead of params since the only used property from AppParameters is chainId

@VanishMax VanishMax requested review from Valentine1898 and a team June 26, 2024 15:06
@VanishMax VanishMax self-assigned this Jun 26, 2024
Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: f4ade13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Valentine1898
Copy link
Contributor

Valentine1898 commented Jun 26, 2024

The thing is that chain_id can change not only when the user changes the RPC
When a new version of the testnet is released, the chain_id changes, but the RPC remains the same

@Valentine1898 Valentine1898 mentioned this pull request Jun 26, 2024
@VanishMax
Copy link
Contributor Author

Closing as it is duplicated by #65

@VanishMax VanishMax closed this Jun 27, 2024
grod220 added a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'params' are never stored in local storage
2 participants