feat(extension): #252: asset list #259
Conversation
|
will also spend some time reviewing today 👍 |
There was a problem hiding this comment.
noticed some UI inconsistencies that need fixing:
- on sub-accounts, the background does not extend to fill the entire height of the extension's window, leaving empty black space.
Screen.Recording.2025-01-07.at.12.26.00.AM.mov
- extension doesn't maintain its fixed position, causing it to partially move out of view and outside the bounds of the extension when scrolling (for instance on sub-account 3, this issue didn’t occur because I couldn't scroll, and the extension remained fixed in place)
Screen.Recording.2025-01-07.at.12.30.25.AM.mov
- noticeable glitches when switching between accounts
Screen.Recording.2025-01-07.at.12.32.58.AM.mov
|
|
||
| return ( | ||
| <> | ||
| <BlockSync /> | ||
|
|
||
| <div className='flex h-full grow flex-col items-stretch gap-[15px] bg-logo bg-left-bottom px-[15px] pb-[15px]'> | ||
| <div className='flex h-full grow flex-col items-stretch gap-[15px] bg-logo bg-[left_-180px] px-[15px] pb-[15px]'> |
There was a problem hiding this comment.
comment: related to the black space issue, I think h-full may not cover the entire extension height?
| </div> | ||
|
|
||
| <ValidateAddress /> | ||
|
|
||
| <div className='shrink-0 grow' /> |
There was a problem hiding this comment.
comment: removing this may be causing the layout issues when scrolling? the position should be fixed to prevent scrolling outside the bounds of the extension
| queryKey: ['balances', account], | ||
| staleTime: Infinity, | ||
| queryFn: async () => { | ||
| return Array.fromAsync(viewClient.balances({ accountFilter: { account } })); |
There was a problem hiding this comment.
comment: what's the error handling fallback here if the view service call, viewClient.balances, fails? we should default to returning an empty balance in that case
| <Table> | ||
| <TableHeader className='group'> | ||
| <TableRow> | ||
| <TableHead>Balance</TableHead> |
There was a problem hiding this comment.
suggestion: can we make UM (and optionally the fee tokens – USDC, OSMO, ATOM) the priority by ordering them higher in the balance list?
|
@TalDerei Thanks for noticing the issues! I addressed them in the latest commit |
| <div className='fixed inset-0 h-full bg-logoImg bg-[left_-180px] bg-no-repeat pointer-events-none' /> | ||
| <div className='fixed inset-0 h-full bg-logo pointer-events-none' /> |
There was a problem hiding this comment.
nit; there's visible discoloration at the bottom of the extension window where the gradient ends. can we add some kind of smooth fading or modify the transparency?
There was a problem hiding this comment.
that's so weird, i can't reproduce
There was a problem hiding this comment.
did a patch fix, no idea if it helps, but at least not breaks anything. Can you create a new issue if the bug persists, so somebody who can reproduce it can fix?
There was a problem hiding this comment.
not necessarily blocking, feel free to merge – filed #264
There was a problem hiding this comment.
thanks @TalDerei
merging this now
Closes #252
Adds the asset table with balances per selected account. Empty if no balances are there for selected account.