Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privacy warning: t-addr #254

Merged
merged 14 commits into from
Dec 22, 2024
Merged

privacy warning: t-addr #254

merged 14 commits into from
Dec 22, 2024

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Dec 18, 2024

adds a privacy warning to the approval dialog if the Ics20Withdrawal message includes a transparent address (t-addr).

CI pipeline is currently failing because this depends on penumbra-zone/web#1950 and requires bumping package dependencies.


Screenshot 2024-12-18 at 11 52 55 AM

@TalDerei TalDerei added the ui Related to user interface or ux design label Dec 18, 2024
@TalDerei TalDerei self-assigned this Dec 18, 2024
@TalDerei
Copy link
Contributor Author

TalDerei commented Dec 18, 2024

need to truncate IBC-address rendering which is currently getting cut-off


Screenshot 2024-12-18 at 1 17 47 PM

updated

Screenshot 2024-12-19 at 3 17 41 AM

@TalDerei TalDerei requested a review from a team December 19, 2024 11:39
@hdevalence
Copy link
Contributor

Shouldn't the updated rendering show "use transparent address" rather than "use compat address"?

@TalDerei
Copy link
Contributor Author

TalDerei commented Dec 20, 2024

Shouldn't the updated rendering show "use transparent address" rather than "use compat address"?

yes, updating approval dialogue to reflect this.

a t-addr has an alternate encoding that is parsed into an Address. The current Ics20WithdrawalComponent in the approval dialogue displays that Address. Should it instead display the tpenumbra encoding format? cc @erwanor

@erwanor
Copy link

erwanor commented Dec 21, 2024

I am not going to block on it, but if we set the transparent flag on, I think it makes sense to render the withdrawal component with a return address encoded as a transparent address.

We do this by adding a PENUMBRA_BECH32_TRANSPARENT_ADDRESS_PREFIX with helpers to the web package @penumbra-zone/bech32. Then, we should be able to display the transparent encoding of an Address. This is how it's done in core: https://github.com/penumbra-zone/penumbra/blob/020986747245270a00d039306458be9e7f1f33f5/crates/core/keys/src/address.rs#L232

Copy link

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on green CI, with requested web changes (other pr) that should make it easy to do taddr rendering in the withdrawal component

@TalDerei
Copy link
Contributor Author

TalDerei commented Dec 22, 2024

We do this by adding a PENUMBRA_BECH32_TRANSPARENT_ADDRESS_PREFIX with helpers to the web package @penumbra-zone/bech32

renders the proper address format in the approval dialogue

Screenshot 2024-12-21 at 10 39 35 PM

@TalDerei TalDerei merged commit f6cff30 into main Dec 22, 2024
3 checks passed
@TalDerei TalDerei deleted the t-addr branch December 22, 2024 17:23
@TalDerei TalDerei mentioned this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to user interface or ux design
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants