-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privacy warning: t-addr #254
Conversation
Shouldn't the updated rendering show "use transparent address" rather than "use compat address"? |
yes, updating approval dialogue to reflect this. a |
I am not going to block on it, but if we set the transparent flag on, I think it makes sense to render the withdrawal component with a return address encoded as a transparent address. We do this by adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, on green CI, with requested web changes (other pr) that should make it easy to do taddr rendering in the withdrawal component
renders the proper address format in the approval dialogue |
adds a privacy warning to the approval dialog if the
Ics20Withdrawal
message includes a transparent address (t-addr).CI pipeline is currently failing because this depends on penumbra-zone/web#1950 and requires bumping package dependencies.