before hook suggestion #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalDerei
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
I had a local branch I hadn’t pushed up, but it's functionally equivalent. I tested the following onboarding flows:
- Seed phrase (mainnet rpc)
- Seed phrase (testnet rpc)
- Import wallet (mainnet rpc) + set wallet birthday height
- Import wallet (testnet rpc) + set wallet birthday height
- Import wallet (mainnet rpc) + without setting the wallet birthday height
- Import wallet (testnet rpc) + without setting the wallet birthday height
the heights display as expected.
TalDerei
added a commit
that referenced
this pull request
Oct 24, 2024
* handle non-mainnet chain id's * linting * migrate logic to grpc page * simplify block height state * before hook suggestion (#220) * extract logic and unit testing --------- Co-authored-by: Gabe Rodriguez <grod220@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for #216
correctBirthdayHeightIfNeededwould require unit tests though