Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'params' are never stored in local storage #32

Closed
Valentine1898 opened this issue Jun 14, 2024 · 0 comments · Fixed by #65
Closed

'params' are never stored in local storage #32

Valentine1898 opened this issue Jun 14, 2024 · 0 comments · Fixed by #65
Assignees
@VanishMax
Labels
bug Something isn't working

Comments

@Valentine1898
Copy link
Contributor

found at #28 (comment)

https://github.com/prax-wallet/web/blob/236e6502a88ca6f5e8e030a0c2a14b9ed521f340/apps/extension/src/wallet-services.ts#L39-L41

We retrieve 'params' from local storage to get the chain-id without having to make any network requests, but in fact the 'params' are always empty because we never save them to local storage

related to penumbra-zone/web#998
@Valentine1898 Valentine1898 added the bug Something isn't working label Jun 14, 2024
@Valentine1898 Valentine1898 mentioned this issue Jun 14, 2024
Merged
@grod220 grod220 added this to Labs web Jun 17, 2024
@grod220 grod220 moved this to 🗄️ Backlog in Labs web Jun 17, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Labs web Jun 20, 2024
@VanishMax VanishMax self-assigned this Jun 26, 2024
@VanishMax VanishMax moved this from 📝 Todo to 🏗 In progress in Labs web Jun 26, 2024
VanishMax added a commit that referenced this issue Jun 26, 2024
@VanishMax
fix(extension): #32: save chainIn in localstorage
f4ade13
@VanishMax VanishMax mentioned this issue Jun 26, 2024
Closed
@turbocrime turbocrime mentioned this issue Jun 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Jun 28, 2024
grod220 added a commit that referenced this issue Dec 3, 2024
@grod220
Cross-extension messaging (#32)
04c1887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VanishMax VanishMax

Labels
bug Something isn't working
Projects
No open projects
Labs web
Archived in project
Milestone
No milestone
2 participants
@Valentine1898 @VanishMax