Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove minifront workaround code #175

Open
turbocrime opened this issue Aug 23, 2024 · 2 comments
Open

remove minifront workaround code #175

turbocrime opened this issue Aug 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@turbocrime
Copy link
Collaborator

#173 is a workaround that should be removed when a new pd ships with a new bundled frontend that does not experience the issue.

i'm filing this issue before #173 merges so i can link an issue URL from a comment in that PR.

@turbocrime turbocrime added the bug Something isn't working label Aug 23, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Aug 23, 2024
@TalDerei
Copy link
Contributor

@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Labs web Oct 16, 2024
@turbocrime
Copy link
Collaborator Author

this was reverted at some point

/**
* Meet the 'request' method of the old page API to mitigate incompatibility
* with pd v0.80.0's bundled minifront. This prevents connection failure.
* @todo Remove when bundled frontends are updated beyond `a31d54a`
* @issue https://github.com/prax-wallet/web/issues/175
*/
request: async () => {
await Promise.resolve(this.port ?? this.postConnectRequest());
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants