Merge pull request opendatahub-io#18 from ROCm/dockerfile_install_mode

make the vllm setup mode configurable and make install mode as defaul…

Dockerfile.rocm

@@ -159,14 +159,17 @@ RUN python3 -m pip install --upgrade pip numba
 RUN python3 -m pip install xformers==0.0.23 --no-deps
 
 # Install vLLM
+ARG VLLM_BUILD_MODE="install"
+# developer might choose to use "develop" mode. But for end-users, we should do an install mode.
+# the current "develop" mode has issues with ImportError: cannot import name '_custom_C' from 'vllm' (/app/vllm/vllm/__init__.py)
 RUN cd /app \
     && cd vllm \
     && pip install -U -r requirements-rocm.txt \
     && if [ "$BUILD_FA" = "1" ]; then \
     bash patch_xformers.rocm.sh; fi \
     && if [ "$BASE_IMAGE" = "rocm/pytorch:rocm6.0_ubuntu20.04_py3.9_pytorch_2.1.1" ]; then \
     patch /opt/rocm/include/hip/amd_detail/amd_hip_bf16.h /app/vllm/rocm_patch/rocm_bf16.patch; fi \
-    && python3 setup.py clean --all && python3 setup.py develop \
+    && python3 setup.py clean --all && python3 setup.py $VLLM_BUILD_MODE \
     && cd ..