Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Accepts empty name as input #148

Closed
sahil-1729 opened this issue May 24, 2023 · 4 comments
Closed

[BUG] Accepts empty name as input #148

sahil-1729 opened this issue May 24, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@sahil-1729
Copy link

Describe the bug

Before starting the game, the game starts without taking name as input

To Reproduce

Steps to reproduce the behavior:
Go to main page
Click on 'Let's Start'
Scroll down to 'name'
Keep name box as empty
Click 'get set go', then 'start now'.
The app continues the game without taking name as input

Expected behavior

The application should have taken the user's name as input before starting the game.

Screenshots

imageimage

Desktop (please complete the following information):

  • OS: WIndows
  • Browser: chrome
  • Version: 113

Additional context

I can fix this by adding a check on the name and displaying an error message wherever required. Please assign this to me under GSSoC'23, as I am GSSoC'23 contributor.

@sahil-1729 sahil-1729 added the bug Something isn't working label May 24, 2023
@github-actions
Copy link

Thanks for raising this issue & giving your bit in this project's development 😇

@gambhirsharma
Copy link
Contributor

@sahil-1729 do you want to work on this issue?

@aishaalsubaie
Copy link

can you assign me this issue @gambhirsharma

@kumarharshh
Copy link

I think this issue is reolved now, I tried to follow your steps, but as I clicked on the get set go button it gave me a alert, that the name field is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants