Add known-answer tests (KATs) #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
This includes the known-answer test hashes from https://github.com/pq-crystals/dilithium/tree/master merged into a single META.yml file. It also includes alternative testvector hashes from PQClean https://github.com/PQClean/PQClean/tree (those also test the detached signature API). Additionally, we copy over a script from mlkem-native that allows querying it. It either uses yq to properly parse the yml, or if that is not available, it falls back to string processing grep which works fine for the simple structure. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
This is automatically executed (also in CI) as a part of quickcheck. This adds known-answer tests following what is done in https://github.com/PQClean/PQClean/blob/master/test/crypto_sign/testvectors.c The main added benefit of this test over the NISTKAT tests is that is also includes the detachted signature API (crypto_sign_signature and crypto_sign_verify). Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
This is executed (in CI) as a part of quickcheck. This adds NISTKAT testvector tests to match the testvector hashes from the official Dilithium implemenetation: https://github.com/pq-crystals/dilithium. Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
jakemas
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5 - that one should be merged first.
This PR adds KAT (matching hashes from PQClean) and NISTKAT (matching hashes from pqcrystals) tests.
Both are added to the quickcheck for all parameter sets - that in turn already is executed in CI.