Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .olz file association on macOS #168

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Add .olz file association on macOS #168

merged 3 commits into from
Apr 4, 2024

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Apr 4, 2024 •
edited by peppy
Loading

@smoogipoo smoogipoo mentioned this pull request Apr 4, 2024
Merged
@peppy peppy self-requested a review April 4, 2024 01:37
peppy
peppy reviewed Apr 4, 2024
View reviewed changes
templates/osu!.app/Contents/Info.plist
<string>Default</string>
<key>CFBundleTypeExtensions</key>
<array>
<string>olz</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much of a muchness, but i do think this can just go in the extensions array above (alongside osz) rather than duplicating, since nothing else if changing.

@peppy peppy merged commit 9896e2e into ppy:master Apr 4, 2024
2 checks passed
@smoogipoo smoogipoo deleted the add-olz-association branch August 31, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoogipoo @peppy