Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows deployment CI and add Windows testing #96

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix Windows deployment CI and add Windows testing #96

merged 1 commit into from
Jan 9, 2025

Conversation

SalomonBrys
Copy link
Contributor

@SalomonBrys SalomonBrys commented Jan 8, 2025 •
edited
Loading

The Windows default shell does not support multi-line commands.
This updates the CI to :

  • Run JVM tests on Linux, Mac & Windows
  • Update run scripts to use the Bash shell (which supports muilti-line commands on all platforms)

@SalomonBrys SalomonBrys marked this pull request as ready for review January 8, 2025 11:10
@DominicGBauer DominicGBauer merged commit bcacef6 into powersync-ja:main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicGBauer DominicGBauer DominicGBauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SalomonBrys @DominicGBauer