wip: try disabling signing for allshared

powersync-ja · Feb 19, 2024 · 3f6ee71 · 3f6ee71
1 parent 39c8de7
commit 3f6ee71
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/KMMBridge-publish.yml b/.github/workflows/KMMBridge-publish.yml
@@ -4,6 +4,12 @@ on:
 #  push:
 #    branches:
 #      - "main"
+
+env:
+  ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_KEY }}
+  ORG_GRADLE_PROJECT_signingInMemoryKeyId : ${{ secrets.SIGNING_KEY_ID }}
+  ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_PASSWORD }}
+
 jobs:
   call-kmmbridge-publish:
     permissions:

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -7,6 +7,7 @@ on:
 
 env:
   ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_KEY }}
+  ORG_GRADLE_PROJECT_signingInMemoryKeyId : ${{ secrets.SIGNING_KEY_ID }}
   ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_PASSWORD }}
 
 jobs:

diff --git a/allshared/build.gradle.kts b/allshared/build.gradle.kts
@@ -30,12 +30,3 @@ kmmbridge {
     mavenPublishArtifacts()
     spm()
 }
-
-signing {
-    val inMemoryKey = project.findProperty("signingInMemoryKey")?.toString()
-    if (inMemoryKey != null) {
-        val inMemoryKeyId = project.findProperty("signingInMemoryKeyId")?.toString()
-        val inMemoryKeyPassword = project.findProperty("signingInMemoryKeyPassword")?.toString().orEmpty()
-        useInMemoryPgpKeys(inMemoryKeyId, inMemoryKey, inMemoryKeyPassword)
-    }
-}
diff --git a/allshared/gradle.properties b/allshared/gradle.properties
@@ -1,2 +1,3 @@
 POM_ARTIFACT_ID = allshared
 POM_NAME = PowerSync iOS Framework
+RELEASE_SIGNING_ENABLED = false
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,6 +7,7 @@ on: @@
     env:
       ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_KEY }}
+      ORG_GRADLE_PROJECT_signingInMemoryKeyId : ${{ secrets.SIGNING_KEY_ID }}
       ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_PASSWORD }}
     jobs:
@@ Expand Down @@