Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler audiences editor / fix scim authentication #498

Merged
merged 19 commits into from
Jan 30, 2025

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Jan 17, 2025

  • Allow setting fetch options to useAudiences
  • Add changelog
  • Bump alpha version
  • Prettier
  • Fix typescript violations:
  • Add more documentation
  • Share audiences via context
  • Initialize useAudiences hook with base URL and key
  • Hardcode scim proxy URL for simplicity
  • Use audience context to fetch users
  • Replace deep prop dependency by Context
  • Initialize useAudiences hook with base URL and key
  • Separate useFetch hooks by HTTP methods
  • Remove unused routes
  • Replace use-http by much smaller and better useFetch
  • Move saving handling to ActionBar
  • Improve typing and error handling in general
  • Bump audiences 1.5.0-alpha1

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=refactor-audiences-contexts

@xjunior xjunior force-pushed the refactor-audiences-contexts branch from 1bc7c98 to dca3e3f Compare January 17, 2025 16:43
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 24 hours if no further activity occurs.
If this change is desirable, please accelerate completing it. If it is not, please close the PR. If you're blocked on something, please ensure there's a reference to this PR in a story on your team's board so the team will follow up, and consider closing the PR for now.
Please do not artificially extend the deadline with a dummy comment. If necessary, provide a status update, such as "this change is being actively tested".
Thank you for your contributions and your collaboration in reducing WIP and cycle time.

@github-actions github-actions bot added the Stale label Jan 21, 2025
@xjunior xjunior removed the Stale label Jan 22, 2025
@xjunior xjunior marked this pull request as ready for review January 28, 2025 15:43
@xjunior xjunior requested a review from a team as a code owner January 28, 2025 15:43
@xjunior xjunior enabled auto-merge (squash) January 30, 2025 19:45
@xjunior xjunior merged commit 1af41ec into main Jan 30, 2025
16 checks passed
@xjunior xjunior deleted the refactor-audiences-contexts branch January 30, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants