Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 本戦試合生成Serviceの実装とテスト #510

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laminne
Copy link
Member

@laminne laminne commented Oct 17, 2024

close #507

やったこと

  • 本戦試合生成Serviceの実装
    • そのテスト

@laminne laminne added 新機能 New feature or request backend Related to kcmsx/kcms labels Oct 17, 2024
@laminne laminne self-assigned this Oct 17, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 93a0bd2
Status: ✅  Deploy successful!
Preview URL: https://a4f8d8f1.kcmsx.pages.dev
Branch Preview URL: https://feat-507-generate-mainmatch.kcmsx.pages.dev

View logs

@laminne laminne marked this pull request as ready for review October 17, 2024 06:02
@laminne laminne enabled auto-merge (squash) October 17, 2024 06:02
const res = await service.handle('1' as TeamID, '2' as TeamID);
expect(Result.isOk(res)).toBe(true);

const team = Result.unwrap(res);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const team = Result.unwrap(res);
const match = Result.unwrap(res);

const res = await service.handle('1' as TeamID, '2' as TeamID);
expect(Result.isOk(res)).toBe(true);

const team = Result.unwrap(res);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const team = Result.unwrap(res);
const match = Result.unwrap(res);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to kcmsx/kcms 新機能 New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

feat: (本戦)試合表の生成の実装
2 participants