Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 試合結果のページを作成 #413

Merged
merged 31 commits into from
Oct 11, 2024
Merged

Conversation

speak-mentaiko
Copy link
Contributor

@speak-mentaiko speak-mentaiko commented Oct 6, 2024

close #58

  • APIをどうしたらよいか分からないため保留

Copy link

cloudflare-workers-and-pages bot commented Oct 6, 2024

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ad1642
Status: ✅  Deploy successful!
Preview URL: https://5f1ce35f.kcmsx.pages.dev
Branch Preview URL: https://feat-58-run-result-page.kcmsx.pages.dev

View logs

@speak-mentaiko speak-mentaiko marked this pull request as ready for review October 6, 2024 14:36
@laminne laminne marked this pull request as draft October 6, 2024 14:44
@speak-mentaiko speak-mentaiko marked this pull request as ready for review October 8, 2024 17:00
Copy link
Contributor

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました。

packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
@speak-mentaiko speak-mentaiko enabled auto-merge (squash) October 10, 2024 04:27
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解決されていなかったため1件unresolveしました。

packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/result.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@speak-mentaiko speak-mentaiko merged commit 67e19a1 into main Oct 11, 2024
4 checks passed
@speak-mentaiko speak-mentaiko deleted the feat/58-run-result-page branch October 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat: 部門別試合結果表示ページを作る
2 participants