Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearance jammy #78

Merged
merged 27 commits into from
Oct 17, 2023
Merged

Appearance jammy #78

merged 27 commits into from
Oct 17, 2023

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Sep 22, 2023

WIP appearance page

@jackpot51
Copy link
Member

I think there is some multi-window issue. After opening the color picker and picking a color, the picker closes and then the whole app panics on line 1363 in iced/sctk/src/application.rs

@wash2
Copy link
Contributor Author

wash2 commented Oct 10, 2023

I think there is some multi-window issue. After opening the color picker and picking a color, the picker closes and then the whole app panics on line 1363 in iced/sctk/src/application.rs

I've not seen this happening yet after using it. Is there a specific color picker or method of closing the color picker window that causes the issue?

@jackpot51
Copy link
Member

I'm not having any panics with the latest update. I'm seeing the custom items below accent color all show up as black, when set to the defaults:

Screenshot_2023-10-11_12-26-44

@wash2
Copy link
Contributor Author

wash2 commented Oct 11, 2023

I'm not having any panics with the latest update. I'm seeing the custom items below accent color all show up as black, when set to the defaults:

Screenshot_2023-10-11_12-26-44

Ya, my understanding is that if nothing is selected, the color picker should appear black. Maybe it should be transparent, or I can try setting the color to the default of the theme if it is left out.

@WatchMkr
Copy link

Ya, my understanding is that if nothing is selected, the color picker should appear black. Maybe it should be transparent, or I can try setting the color to the default of the theme if it is left out.

Let's set it to the default of the theme if it hasn't been changed or is reset.

@wash2
Copy link
Contributor Author

wash2 commented Oct 12, 2023

Oh actually, maybe it could be good if the color pickers in general display the + when no color is selected, like the accent color picker in figma?

@wash2 wash2 marked this pull request as ready for review October 16, 2023 21:25
@wash2 wash2 requested a review from a team October 16, 2023 21:26
@wash2 wash2 merged commit 0b74b0e into master_jammy Oct 17, 2023
3 checks passed
@wash2 wash2 deleted the appearance_jammy branch October 17, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants