-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for profiling using tracy #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should just drop puffin?
Looks like |
Right. It doesn't hurt to also have puffin-egui available inside the compositor I guess. But we definitely don't want special puffin calls, where we could just use profiling. |
Seems |
|
2d91d21
to
2d4845c
Compare
Rebased on |
I mean we do have cosmic-screenshot now, so maybe we can drop the code for creating window screenshots now? That is the only thing that needs the local clock for formatting the file name. |
Oh, actually that part can be addressed by temporarily using I've committed more I also This should be fine to merge, and would be useful to have in |
I'm not sure entirely how to deal with
profiling::finish_frame!
when there are multiple outputs rendering frames, and some more functions could be annotated, but Tracy seems generally useful for profiling with these changes. So they might as well be merged.