Enable wlr_data_control protocol

[xDarksome]

Resolves #99

[xDarksome]

@Drakulix what is the best way to test Wayland <-> X clipboard integration? I don't actually use any X clients.

I tried xclip , but it behaves like a separate clipboard, in hyprland as well. So I'm not sure whether it's a bug on my side.

[Drakulix]

I tried xclip , but it behaves like a separate clipboard, in hyprland as well. So I'm not sure whether it's a bug on my side.

You would have to use xclip with the -selection clipboard argument, but even then I am not sure it will work, given cosmic will deny X11 clipboard access if no X11 window has focus.

You can start some terminals, text editors, browsers etc forcing them to go through Xwayland by unsetting WAYLAND_DISPLAY, when launching them.

[xDarksome]

First day of daily driving went fine. Experienced only a single crash 😄
I'm going to test it more during the week.

[Drakulix]

First day of daily driving went fine. Experienced only a single crash smile

Sounds good! Please give me a ping once this is ready for a proper review. :)

[xDarksome]

@Drakulix I'm not planning to do any changes, unless I find some bugs. The crash I experienced today is unrelated, it's something about switching tilingmode + using fullscreen, but I'm not sure yet. I'll file a bug report, once I identify it more clearly.

I still need to verify X-wayland clipboard integration, which I'm going to do sometime this week. But the PR may be considered ready for review. Although it's no rush as I'm already using it and don't care that much about when it's going to hit upstream.

[xDarksome]

Selection sources used:

• Firefox with MOZ_WAYLAND_ENABLE=0 (xwayland)
• Gedit with GDK_BACKEND=x11 (xwayland)
• Alacritty (native wayland)
• wl-clipboard (data_control)

Results of manual testing (master):
✔️ xwayland clipboard -> data_device
❌ data_device -> xwayland clipboard (See *behavior A)
❌ xwayland primary -> primary_selection (nothing happens)
❌ primary_selection -> xwayland primary (See *behavior B)

Results of manual testing (this PR):
✔️ xwayland clipboard -> data_device
❌ data_device -> xwayland clipboard (See *behavior A)
❌ xwayland primary -> primary_selection (nothing happens)
❌ primary_selection -> xwayland primary (See *behavior B)

✔️ xwayland clipboard -> data_control
❌ data_control -> xwayland clipboard (See *behavior A)
❌ xwayland primary -> data_control (nothing happens)
❌ data_control -> xwayland primary (selection is not being applied at all, maybe bug on my side)

✔️ data_control <-> data_device
✔️ primary_selection -> data_control
❌ data_control -> primary_selection (nothing happens)

*behavior A - First time pressing CTRL-V inside the window works fine, then nothing happens and this being printed in logs: WARN Mime type requested by X client not offered. Then it sometimes works if you copy and paste quick enough 🙃 (seems like the selection is being asynchronously dropped somehow somewhere)

*behavior B - Similar to A, but we don't have this 100% working the first try, and we immediately get into the nondeterministic behavior when it sometimes work depending on how quick you are

My general conclusion is: there is maybe one bug on my side related to (data_control -> xwayland primary) route. Everything else seems unrelated to this PR. There seem to be multiple bugs in xwayland and primary_selection implementations in smithay, though.

[Drakulix]

Thanks for the detailed report and reproduction instructions, very much appreciated.
I will try to replicate these issue and merge fixes together with your work on the data-control protocol soon. I am currently just a little busy with a bunch of shell changes.

[kchibisov]

The upstream smithay has support for this protocol now which works with any sort of direction. So this could be closed now, I guess.

[xDarksome]

Switched to the Smithay implementation, works fine for my usecase.
Haven't tested all the possible combinations

[Drakulix]

Thanks! Sorry this took so long, but with the new changes this is quite easy to review now. 😅

[rafaeldelboni]

Hi sorry to necro bump this, but how can I use this, I saw this feature is behind a config data_control_enabled, but is not clear to me where enable it.

[xDarksome]

Hi sorry to necro bump this, but how can I use this, I saw this feature is behind a config data_control_enabled, but is not clear to me where enable it.

Seems like it requires this env var to be set now

cosmic-comp/src/state.rs

Line 531 in afdb656

let data_control_state = std::env::var("COSMIC_DATA_CONTROL_ENABLED")