Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/pony.peg is missing definitions #45

Closed
SeanTAllen opened this issue Dec 24, 2023 · 2 comments · Fixed by #47
Closed

examples/pony.peg is missing definitions #45

SeanTAllen opened this issue Dec 24, 2023 · 2 comments · Fixed by #47
Assignees
@SeanTAllen

Comments

@SeanTAllen
Copy link
Member

The pony.peg grammar file is missing definitions and fails to work. For example, doing:

Note to see this error, you have to be on main. There's a different bug hiding this in 0.1.5

Here's a snippet of the long long error output.

peg/examples on  main ➜ ../build/release/compiler pony.peg ../peg/ast.pony
-- Missing Definition --

/home/sean/code/ponylang/peg/examples/pony.peg:3:51:5

3: use <- -"use" (ID -"=")? (STRING / useffi) (-"if" infix)?
                                                     ^^^^^
                                                     rule has not been defined

One of the parse rules references another rule that has not been defined.


-- Missing Definition --

/home/sean/code/ponylang/peg/examples/pony.peg:5:29:8

5: useffi <- "@" (ID / STRING) typeargs -"(" params? -")" "?"?
                               ^^^^^^^^
                               rule has not been defined
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Dec 24, 2023
@SeanTAllen SeanTAllen mentioned this issue Dec 24, 2023
Open
@SeanTAllen
Copy link
Member Author

Given the large number of missing definitions, I think we should remove pony.peg and any associated mention that might be in README's etc.

@SeanTAllen SeanTAllen added bug needs discussion Needs to be discussed further labels Dec 24, 2023
@SeanTAllen
Copy link
Member Author

We decided during sync to delete the pony.peg.

@SeanTAllen SeanTAllen removed discuss during sync Should be discussed during an upcoming sync needs discussion Needs to be discussed further labels Jan 9, 2024
@SeanTAllen SeanTAllen self-assigned this Jan 9, 2024
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 9, 2024
SeanTAllen added a commit that referenced this issue Jan 9, 2024
@SeanTAllen
Remove broken pony.peg
7fb3743 
The pony.peg grammar hasn't work for any release that we've ever
done for ponylang/peg. I believe it worked once, a long long time ago.

If someone wanted to bring back, that is fine, but at the moment, it
is merely a source of confusion.

Closes #45
@SeanTAllen SeanTAllen mentioned this issue Jan 10, 2024
Merged
@SeanTAllen SeanTAllen removed the discuss during sync Should be discussed during an upcoming sync label Jan 10, 2024
SeanTAllen added a commit that referenced this issue Jan 16, 2024
@SeanTAllen
Remove broken pony.peg (#47)
14f00da 
The pony.peg grammar hasn't work for any release that we've ever
done for ponylang/peg. I believe it worked once, a long long time ago.

If someone wanted to bring back, that is fine, but at the moment, it
is merely a source of confusion.

Closes #45
@SeanTAllen SeanTAllen removed the bug label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanTAllen SeanTAllen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove broken pony.peg ponylang/peg
2 participants
@SeanTAllen @ponylang-main