Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Build Issues #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing Build Issues #19

wants to merge 4 commits into from

Conversation

larron
Copy link

@larron larron commented Sep 11, 2023

Hey guys,

I ran into a TypeScript build issue when attempting to use this package.
It turned out that it actually wasn't this package directly but instead the underlying Aptos dependency that had some TS issues.

When I went to upgrade the Aptos dependency to see if it would fix the issue, I noticed that this package had Aptos listed in both normal dependencies and peer dependencies. I've removed it from dependences and left it solely in peer, this way the root project can decide what version of Aptos to install.

Additionally, the package failed to build when installing directly from github so I made sure the tsconfig.json which is needed to build and prepare the package now exists (by adding it to files in package.json) and last but not least I've added a prepare step to build the project on install.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant