Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
I ran into a TypeScript build issue when attempting to use this package.
It turned out that it actually wasn't this package directly but instead the underlying Aptos dependency that had some TS issues.
When I went to upgrade the Aptos dependency to see if it would fix the issue, I noticed that this package had Aptos listed in both normal dependencies and peer dependencies. I've removed it from dependences and left it solely in peer, this way the root project can decide what version of Aptos to install.
Additionally, the package failed to build when installing directly from github so I made sure the
tsconfig.json
which is needed to build and prepare the package now exists (by adding it to files in package.json) and last but not least I've added aprepare
step to build the project on install.Thanks