Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help text for experimental conditions in PHI-Canto #2299

Closed
jseager7 opened this issue Jun 9, 2020 · 17 comments
Closed

Add help text for experimental conditions in PHI-Canto #2299

jseager7 opened this issue Jun 9, 2020 · 17 comments

Comments

@jseager7
Copy link
Collaborator

jseager7 commented Jun 9, 2020

Requested by @CuzickA in PHI-base/phi-eco#10 (comment)

The following text or similar would be useful to add to the conditions selection page
'Please add experimental conditions, conditions are aspects of the experimental setup independent of the genotype of the species under study ie pathogen/host strain or construct. They include any third party species used as a experimental assay system (heterologous species).

This is the text that needs to be customised:

image

@kimrutherford This will probably involve adding another configuration property that defaults to the text that's already there. The solution could follow what we did for the custom text on the finish form:

curs_config:
  finish_form:
    extra_text_gene_information: >
      <p>
        Examples include:
        <ul>
        <li> protein domain data or other protein sequence features
        <li> missing gene names (synonyms)
        <li> transcriptional regulation (of the wild-type allele - transcriptional changes due to mutations can be captured in Canto)
        <li> complementation data (whether the gene complements a homologue in a different organism or vice versa; complementation may be full, partial or absent)
        <li> gene product name updates
        </ul>
        Most of these annotation types will be handled in future releases of the
        curation tool.
      </p>

If you're happy to explain how to add new configuration properties, then I'm happy to handle this myself.

@jseager7
Copy link
Collaborator Author

jseager7 commented Jun 9, 2020

The solution could follow what we did for the custom text on the finish form:

Although in this case we probably don't need any rich formatting, so the configuration value could just be a plain string in the manner of the help text for annotations:

    help_text: >
      A protein modification is a covalent modification or other change that
      alters the measured molecular mass of a peptide or protein amino acid
      residue

@jseager7
Copy link
Collaborator Author

@CuzickA Would you want the following help text added on each phenotype annotation type? Based on the wording, it seems like it's most relevant for pathogen phenotype and host phenotype annotations.

Please add experimental conditions, conditions are aspects of the experimental setup independent of the genotype of the species under study i.e. pathogen/host strain or construct. They include any third party species used as a experimental assay system (heterologous species)

If we want the same text on metagenotype phenotypes, we may want to amend the wording as follows:

...conditions are aspects of the experimental setup independent of the metagenotype containing the species under study i.e. pathogen/host strain or construct.

Note that experimental conditions don't apply to GO annotations.

@ValWood
Copy link
Member

ValWood commented Jan 26, 2021

Personally I don't think this full text will be required. The part about delivery system, which is the only thing people will need to know up front would get a little lost. I would shorten it to

"Delivery mechanisms, including the use of third party species used for expression of the studied protein are captured in conditions" (or similar)

Also, the point of confusion is really during genotype creation, not phenotype curation so it probably needs to be at the point where people add genes and species.

@ValWood
Copy link
Member

ValWood commented Jan 26, 2021

"Delivery mechanisms, including the use of third party species used for expression of the studied protein are captured in conditions, and do not need to be included. here" (or similar)

@jseager7
Copy link
Collaborator Author

Also, the point of confusion is really during genotype creation, not phenotype curation so it probably needs to be at the point where people add genes and species.

I'm a bit confused about this. Do you want the notice shown on the 'Gene and host organism list' page at the start of the session, or when the user is creating genotypes on the Genotype Management page? It sounds like it's more sensible to stop curators adding species just because they were used as delivery mechanisms, so I'm guessing you meant the start?

We might still want to consider some help text near the experimental conditions in case users forget that they should be specifying the delivery mechanism once they get to that point of the curation session. If they're only notified at the start of the session they might forget by the time they get to phenotype annotation.

@CuzickA
Copy link
Collaborator

CuzickA commented Jan 26, 2021

My notes say that we decided to
i) add help text to the metagenotype management page as a pop up that 'delivery mechanism will be captured later'
ii) add text to the 'conditions' section about selecting 'delivery mechanism' here. (Will eventually move to its own selectable box under/after conditions).

@ValWood
Copy link
Member

ValWood commented Jan 26, 2021

We did discuss on the metagenotype page (and it will probably be useful there too), but I think people might try to add the 3rd party species even earlier (they would need to do this to include it in a metagenotype, which would be the correct thing to do if we interpreted this construct sensu stricto (it really is the new symbiont + the gene of interest) , but doing this defeats the object of what the experimenter is trying to achieve ( which is how a particular gene interacts with a host).

@ValWood

This comment has been minimized.

@CuzickA
Copy link
Collaborator

CuzickA commented Feb 3, 2021

@CuzickA

This comment has been minimized.

@jseager7

This comment has been minimized.

@ValWood

This comment has been minimized.

@CuzickA
Copy link
Collaborator

CuzickA commented Feb 3, 2021

I think with the help prompts, and because the strings are now easy to find we should probably continue as we are. Another field won't particularly help if the help text is clear. Useful to get feedback from everyone though.

I agree :-)

@jseager7
Copy link
Collaborator Author

jseager7 commented Apr 19, 2021

Finally remembered that I need to add some text to the edit genes page in PHI-Canto that will remind curators not to add species to the curation session if they are only used as a delivery mechanism. Here's the draft text:

Note: Do not add species here if their only use is as a delivery mechanism. Information about delivery mechanisms should be added later, as an experimental condition.

We agreed to do this in the meeting on 8 February. My plan is to add the note as a separate paragraph under the existing note about NCBI Taxonomy ID re-mapping. Here's how that will look:

image

If anyone thinks it would be better to combine the notes into one section (or can think of any better way to present this information), I'm happy to change it.

@ValWood @CuzickA Do you have any comments?

@CuzickA
Copy link
Collaborator

CuzickA commented Apr 19, 2021

Looks good to me

@ValWood
Copy link
Member

ValWood commented Apr 19, 2021

and me. If anything is confusing in practice we can tweak later.

@jseager7
Copy link
Collaborator Author

Thanks. The text should be visible by tomorrow when the PHI-Canto servers are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants