-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add help text for experimental conditions in PHI-Canto #2299
Comments
Although in this case we probably don't need any rich formatting, so the configuration value could just be a plain string in the manner of the help text for annotations: help_text: >
A protein modification is a covalent modification or other change that
alters the measured molecular mass of a peptide or protein amino acid
residue |
@CuzickA Would you want the following help text added on each phenotype annotation type? Based on the wording, it seems like it's most relevant for pathogen phenotype and host phenotype annotations.
If we want the same text on metagenotype phenotypes, we may want to amend the wording as follows:
Note that experimental conditions don't apply to GO annotations. |
Personally I don't think this full text will be required. The part about delivery system, which is the only thing people will need to know up front would get a little lost. I would shorten it to "Delivery mechanisms, including the use of third party species used for expression of the studied protein are captured in conditions" (or similar) Also, the point of confusion is really during genotype creation, not phenotype curation so it probably needs to be at the point where people add genes and species. |
"Delivery mechanisms, including the use of third party species used for expression of the studied protein are captured in conditions, and do not need to be included. here" (or similar) |
I'm a bit confused about this. Do you want the notice shown on the 'Gene and host organism list' page at the start of the session, or when the user is creating genotypes on the Genotype Management page? It sounds like it's more sensible to stop curators adding species just because they were used as delivery mechanisms, so I'm guessing you meant the start? We might still want to consider some help text near the experimental conditions in case users forget that they should be specifying the delivery mechanism once they get to that point of the curation session. If they're only notified at the start of the session they might forget by the time they get to phenotype annotation. |
My notes say that we decided to |
We did discuss on the metagenotype page (and it will probably be useful there too), but I think people might try to add the 3rd party species even earlier (they would need to do this to include it in a metagenotype, which would be the correct thing to do if we interpreted this construct sensu stricto (it really is the new symbiont + the gene of interest) , but doing this defeats the object of what the experimenter is trying to achieve ( which is how a particular gene interacts with a host). |
This comment has been minimized.
This comment has been minimized.
See also PHI-base/curation#69 and https://docs.google.com/spreadsheets/d/1D39pqcpO5mxr_wVCgYWtVGEujqV3Pq1LJZTug3WF4TI/edit#gid=0 for current delivery mechanism terms |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I agree :-) |
Finally remembered that I need to add some text to the edit genes page in PHI-Canto that will remind curators not to add species to the curation session if they are only used as a delivery mechanism. Here's the draft text:
We agreed to do this in the meeting on 8 February. My plan is to add the note as a separate paragraph under the existing note about NCBI Taxonomy ID re-mapping. Here's how that will look: If anyone thinks it would be better to combine the notes into one section (or can think of any better way to present this information), I'm happy to change it. |
Looks good to me |
and me. If anything is confusing in practice we can tweak later. |
Thanks. The text should be visible by tomorrow when the PHI-Canto servers are updated. |
Requested by @CuzickA in PHI-base/phi-eco#10 (comment)
This is the text that needs to be customised:
@kimrutherford This will probably involve adding another configuration property that defaults to the text that's already there. The solution could follow what we did for the custom text on the finish form:
If you're happy to explain how to add new configuration properties, then I'm happy to handle this myself.
The text was updated successfully, but these errors were encountered: