Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alloy&mmr dependencies #362

Closed
wants to merge 2 commits into from

Conversation

kku9706
Copy link

@kku9706 kku9706 commented Jan 2, 2025

No description provided.

@seunlanlege
Copy link
Member

Why should we upgrade the MMR?

@gavofyork
Copy link

image

^^^ Eeek

@kku9706
Copy link
Author

kku9706 commented Jan 3, 2025

Why should we upgrade the MMR?

Somehow be consistent with https://github.com/paritytech/polkadot-sdk/blob/f3ab3854e1df9e0498599f01ba4f9f152426432a/substrate/frame/merkle-mountain-range/src/mmr/storage.rs#L141

Though It may not be necessary, is it possible to reuse the MMR library from Parity directly?

@kku9706
Copy link
Author

kku9706 commented Jan 3, 2025

About rust toolchain, does https://github.com/paritytech/dockerfiles/blob/2ab2cf3a4efb4a4f7539f42b064c8a42d308d450/ci-unified/Dockerfile#L91
mean Parity already updated to use 1.81?

@seunlanlege
Copy link
Member

Unfortunately, given how sensitive the mmr is to the safety of Hyperbridge, the fact that it is already deployed on mainnet, alongside solidity verifiers, we will not be upgrading the mmr.

The current version in use (v0.5.2) underwent significant audits and testing to ensure safety and compatibility with the solidity-merkle-trees library. Which is used for mmr verification on evm chains.

Now polkadot-sdk seems to be using a fork built on the v0.6.0 version which is quite concerning given they include the v0.5.2 in their root Cargo.toml but actually use a different version in sp-mmr-primitives.

We will however, take some time to investigate in detail the diff between 0.5.2 and 0.6.0 once we have the bandwidth to do so.

@kku9706 Do not be dismayed, you are welcome to contribute by tackling our other open issues
https://github.com/polytope-labs/hyperbridge/issues

@seunlanlege seunlanlege closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants