Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Force Auto Fullscreen is broken since 0.24.0 #254

Closed
7 tasks done
RAPXT opened this issue Oct 3, 2022 · 3 comments
Closed
7 tasks done

Force Auto Fullscreen is broken since 0.24.0 #254

RAPXT opened this issue Oct 3, 2022 · 3 comments
Labels
bug Something isn't working tubular Planned for the Tubular rebranding

Comments

@RAPXT
Copy link

RAPXT commented Oct 3, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I am not able to reproduce the bug with the same version of upstream NewPipe.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.0

Steps to reproduce the bug

Tap on Hamburger menu -> Settings -> Extras -> Enable "Force Auto Fullscreen"

Select a video and press play, the video should now start in fullscreen. But instead the video starts in a mini player.

I have also tried it with version 0.23.3 and it was working there, so it's broken since 0.24.0.

Thank you for your time & dedication ❤️

Expected behavior

No response

Actual behavior

No response

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

No response

@RAPXT RAPXT added the bug Something isn't working label Oct 3, 2022
@Atemu
Copy link

Atemu commented Oct 4, 2022

How does upstream NewPipe behave?

@RAPXT
Copy link
Author

RAPXT commented Oct 4, 2022

Upstream NewPipe doesn't have this exact feature, which I described above, where it can be found.

But it has a similar feature, which can be found under:
Hamburger menu -> Settings -> Video and audio -> Behavior -> "Start main player in full screen"

I've enabled it and restarted the app. On version 0.24.0 it doesn't work (the video starts in mini-player instead of fullscreen). On version 0.23.3 it's also broken.

Summary: On upstream NewPipe it's at least broken since the last two versions.

On NewPipe SponsorBlock it was working till version 0.23.3 and is broken since version 0.24.0.

@RAPXT RAPXT closed this as completed Oct 4, 2022
@RAPXT RAPXT reopened this Oct 4, 2022
@polymorphicshade polymorphicshade added the tubular Planned for the Tubular rebranding label Oct 16, 2022
@RAPXT
Copy link
Author

RAPXT commented Nov 28, 2023

I'll close this issue, since upstream NewPipe and also your fork now work without issue.

Thank you for making this fork!

@RAPXT RAPXT closed this as completed Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working tubular Planned for the Tubular rebranding
Projects
None yet
Development

No branches or pull requests

3 participants