Update setup-scraper.mdx #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Profiling-config section
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brancz
approved these changes
Apr 29, 2025
docs/setup-scraper.mdx
Outdated
| ``` | ||
| - job_name: your-job-name | ||
| profiling_config: | ||
| pprof_config: |
There was a problem hiding this comment.
indentation is off here, pprof_config is a child of profiling_config
brancz
reviewed
Apr 30, 2025
docs/setup-scraper.mdx
Outdated
|
|
||
| Example: | ||
| ``` | ||
| custom: |
There was a problem hiding this comment.
that's not right, it needs to be under pprof_config
docs/setup-scraper.mdx
Outdated
| @@ -235,7 +235,7 @@ This configurability allows Polar Signals customers to: | |||
| ``` | |||
| - job_name: your-job-name | |||
| profiling_config: | |||
| pprof_config: | |||
| pprof_config: | |||
There was a problem hiding this comment.
the indentation is wrong here, it should only be 2 spaces, not 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Profiling-config section