Rds/cml/function get hvac systems primarily serving comp rooms #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarpman
reviewed
Mar 30, 2023
| - Reset space_is_a_computer_room to false: `space_is_a_computer_room = false` | ||
| - Reset total_Wattage_space: `total_Wattage_space = 0` | ||
| - Get the area (ft^2) of the space: `area = space.floor_area` | ||
| - Check if space is of type computer room, if yes then set the space is a computer room boolean variable to true (if lighting space type is undefined it will always be false - maybe we should check is misc is above 20 W/sf if this is undefined?): `if space_x.lighting_space_type in ["COMPUTER_ROOM"]: space_is_a_computer_room = true` |
There was a problem hiding this comment.
I agree that it may be good to check for 20 W/SF and treat spaces that meet this definition but do not have space type provided as computer rooms. But if we do that, we should also use this criteria for get_zones_computer_rooms function. Perhaps we should have a function is_computer_room that both this RDS and the get_zones_computer_rooms function would call.
| - Add to the running Wattage total for the space: `total_Wattage_space = total_Wattage_space + temp_total_power` | ||
|
|
||
| - Add to the total Wattage across all spaces serving zone: `total_Wattage_zone = total_Wattage_zone + total_Wattage_space` | ||
| - Check if the space serves a computer room: `if space_is_a_computer_room == true: total_Wattage_including_computer_rooms_only_zone = total_Wattage_including_computer_rooms_only_zone + total_Wattage_space` |
There was a problem hiding this comment.
total_Wattage_including_computer_rooms_only_zone make is a little confusing. Shouldn't it be total_Wattage_of_computer_rooms_only?
mkarpman
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.