RCT/JDJ/validation associated list length #1643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilixu
approved these changes
Feb 24, 2025
| if has_key_1 or has_key_2: | ||
| if not (has_key_1 and has_key_2): # One key is missing | ||
| mismatch_errors.append( | ||
| f"'{obj['id']}' has populated '{key_1 if has_key_1 else key_2}' but is missing '{key_1 if not has_key_1 else key_2}'." |
There was a problem hiding this comment.
Is this function run after the schema validation? Just making sure the ["id"] is well covered.
| for obj in object_list: | ||
| for key_1, key_2 in associated_list_data_elements: | ||
| has_key_1 = key_1 in obj | ||
| has_key_2 = key_2 in obj |
There was a problem hiding this comment.
Another way to do it - save an if
for obj in object_list:
for key_1, key_2 in associated_list_data_elements:
val_1, val_2 = obj.get(key_1, None), obj(key_2, None)
# XOR operation
if val_1 is None != val_2 is None:
mismatch_errors.append(
f"'{obj['id']}' has populated '{key_1 if val_1 else key_2}' but is missing '{key_1 if not val_1 else key_2}'."| isinstance(val_1, list) | ||
| and isinstance(val_2, list) | ||
| and len(val_1) != len(val_2) | ||
| ): |
There was a problem hiding this comment.
If schema validation has run before this function, then here you can simply do val_1 and val_2 and len(val_1) != len(val_2)
But I do also like to check for list to specify these values shall be list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.