Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: --configfile option - related to issue 1542 #7290

Closed
TomMelt opened this issue Feb 5, 2025 · 1 comment · Fixed by #7295
Closed

hydra: --configfile option - related to issue 1542 #7290

TomMelt opened this issue Feb 5, 2025 · 1 comment · Fixed by #7295
Assignees

Comments

@TomMelt
Copy link

TomMelt commented Feb 5, 2025

I commented at the bottom of issue #1542. But I think it might not get picked up.

Feel free to close this if you don't want duplication, but the previous issue was closed as solved.

My comments on issues 1542 below

FWIW I am experiencing the same issue with --configfile in version:

$ mpichversion 
MPICH Version:      4.2.3
MPICH Release date: Wed Oct  2 09:35:21 AM CDT 2024
MPICH ABI:          16:3:4
MPICH Device:       ch4:ofi
MPICH configure:    --prefix=/software/spack/opt/spack/linux-ubuntu24.04-skylake/gcc-13.3.0/mpich-4.2.3-znn2tyjor4f43jtjwfshemtd4reor6de --disable-maintainer-mode --disable-silent-rules --enable-shared --with-pm=hydra --enable-romio --without-ibverbs --enable-wrapper-rpath=yes --with-yaksa=/software/spack/opt/spack/linux-ubuntu24.04-skylake/gcc-13.3.0/yaksa-0.3-2sgm4n4mh6ffoyi77oap2jvnhixl7mhp --without-ze --with-hwloc=/software/spack/opt/spack/linux-ubuntu22.04-x86_64_v3/gcc-11.4.0/hwloc-2.11.1-fwtuzgpmp2dy3udiekh6nwnbcld22kmk --enable-fortran --with-slurm=no --without-cuda --without-hip --with-device=ch4:ofi --with-libfabric=/software/spack/opt/spack/linux-ubuntu24.04-skylake/gcc-13.3.0/libfabric-1.22.0-dxsgzhbyeaygi6rqaqwx5wywf2gq424u --enable-libxml2 --with-datatype-engine=auto
MPICH CC:           /software/spack/lib/spack/env/gcc/gcc    -O2
MPICH CXX:          /software/spack/lib/spack/env/gcc/g++   -O2
MPICH F77:          /software/spack/lib/spack/env/gcc/gfortran   -O2
MPICH FC:           /software/spack/lib/spack/env/gcc/gfortran   -O2
MPICH features:     threadcomm

e.g.,

$ cat config
-n 1 echo "hi"
-n 2 echo "hello"
$ mpirun --configfile config
"hi" -n 2 echo "hello"

Whereas, if I add a colon : I get the correct behavior.

$ cat config2 
-n 1 echo "hi" :
-n 1 echo "hello"
$ mpirun --configfile config2
"hi"
"hello"

Should I open this as a separate issue?

@hzhou
Copy link
Contributor

hzhou commented Feb 5, 2025

Yes, it is a known bug that we never got around to fix. I'll take a stab at it.

@hzhou hzhou self-assigned this Feb 5, 2025
@hzhou hzhou changed the title configfile bug - related to issue 1542 hydra: --configfile option - related to issue 1542 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants