Skip to content

Identify candidates for deprecation in the fracs subfolder #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keileg opened this issue Apr 10, 2025 · 1 comment
Open

Identify candidates for deprecation in the fracs subfolder #1403

keileg opened this issue Apr 10, 2025 · 1 comment
Assignees

Comments

@keileg
Copy link
Contributor

keileg commented Apr 10, 2025

Depending on confidence, outdated, unused, or otherwise hopeless code can be:

  1. Marked for deprecation (see template below),
  2. Brought up for discussion in the core developer group (or a subset). Please make a list of discussion points, if any, in this issue, with links to the relevant part of the code.
  3. In extreme cases, simply deleted.

How to mark for deprecation:
``python
import warnings

...
msg = "This functionality is deprecated and will be removed in a future version"
warnings.warn(msg, DeprecationWarning)

For examples, search for 'deprecation' in the code base.
@keileg keileg self-assigned this Apr 10, 2025
@keileg
Copy link
Contributor Author

keileg commented Apr 15, 2025

Import of fracture information from a .fab format will be deprecated.

Beyond this, it is clear that the whole folder is ripe for a full restructuring, but that will be a major undertaking that cannot be prioritized for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant