fix: use SCRIPT_NAME instead of REQUEST_URI to check path (#585) #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
added a commit
that referenced
this pull request
May 16, 2024
The script is currently checking if the `REQUEST_URI` is containing `wp-comments-post.php`, the default script to handle the submission of a comment. Some security plugins have options to rename this file to disguise that WordPress is used. With this fix, the `SCRIPT_NAME` is used instead. Since many security plugins do use rewrite rules, while the `REQUEST_URI` value is changed, the `SCRIPT_NAME` value stays the same. Therefor the condition would still recognize if a comment was submitted. Original fix by @2ndkauboy in #589, adapted to v3.
stklcode
force-pushed
the
fix/use-script-name
branch
from
54d7052 to
3c110f0
Compare
The script is currently checking if the `REQUEST_URI` is containing `wp-comments-post.php`, the default script to handle the submission of a comment. Some security plugins have options to rename this file to disguise that WordPress is used. With this fix, the `SCRIPT_NAME` is used instead. Since many security plugins do use rewrite rules, while the `REQUEST_URI` value is changed, the `SCRIPT_NAME` value stays the same. Therefor the condition would still recognize if a comment was submitted. Original fix by @2ndkauboy in #589, adapted to v3.
stklcode
added a commit
that referenced
this pull request
May 16, 2024
The script is currently checking if the `REQUEST_URI` is containing `wp-comments-post.php`, the default script to handle the submission of a comment. Some security plugins have options to rename this file to disguise that WordPress is used. With this fix, the `SCRIPT_NAME` is used instead. Since many security plugins do use rewrite rules, while the `REQUEST_URI` value is changed, the `SCRIPT_NAME` value stays the same. Therefor the condition would still recognize if a comment was submitted. Original fix by @2ndkauboy in #589, adapted to v3.
stklcode
force-pushed
the
fix/use-script-name
branch
from
3c110f0 to
e89b9b7
Compare
stklcode
changed the title
stklcode
added a commit
that referenced
this pull request
May 22, 2024
The script is currently checking if the `REQUEST_URI` is containing `wp-comments-post.php`, the default script to handle the submission of a comment. Some security plugins have options to rename this file to disguise that WordPress is used. With this fix, the `SCRIPT_NAME` is used instead. Since many security plugins do use rewrite rules, while the `REQUEST_URI` value is changed, the `SCRIPT_NAME` value stays the same. Therefor the condition would still recognize if a comment was submitted. Original fix by @2ndkauboy in #589, adapted to v3.
stklcode
force-pushed
the
fix/use-script-name
branch
from
e89b9b7 to
73fc738
Compare
2ndkauboy
pushed a commit
that referenced
this pull request
Nov 1, 2024
The script is currently checking if the `REQUEST_URI` is containing `wp-comments-post.php`, the default script to handle the submission of a comment. Some security plugins have options to rename this file to disguise that WordPress is used. With this fix, the `SCRIPT_NAME` is used instead. Since many security plugins do use rewrite rules, while the `REQUEST_URI` value is changed, the `SCRIPT_NAME` value stays the same. Therefor the condition would still recognize if a comment was submitted. Original fix by @2ndkauboy in #589, adapted to v3.
2ndkauboy
force-pushed
the
fix/use-script-name
branch
from
73fc738 to
a971124
Compare
2ndkauboy
approved these changes
Nov 1, 2024
|
@stklcode sorry that I've missed this already existing PR. Yours fixes one more place I've missed. And it adds test! 🙌 So please feel free to merge it now. |
stklcode
force-pushed
the
fix/use-script-name
branch
from
a971124 to
53e0de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script is currently checking if the
REQUEST_URIis containingwp-comments-post.php, the default script to handle the submission of a comment. Some security plugins have options to rename this file to disguise that WordPress is used.With this fix, the
SCRIPT_NAMEis used instead. Since many security plugins do use rewrite rules, while theREQUEST_URIvalue is changed, theSCRIPT_NAMEvalue stays the same. Therefor the condition would still recognize if a comment was submitted.Original fix by @2ndkauboy in #589, adapted to v3.