nav sorting improved & systemchecker types

ploi · Jan 10, 2024 · ffcc2f9 · ffcc2f9
1 parent c7c4a93
commit ffcc2f9
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 7 deletions.
diff --git a/app/Filament/Resources/CommentResource.php b/app/Filament/Resources/CommentResource.php
@@ -18,6 +18,8 @@ class CommentResource extends Resource
 
     protected static ?string $navigationGroup = 'Manage';
 
+    protected static ?int $navigationSort = 104;
+
     public static function form(Form $form): Form
     {
         return $form

diff --git a/app/Filament/Resources/InboxResource.php b/app/Filament/Resources/InboxResource.php
@@ -24,6 +24,7 @@ class InboxResource extends Resource
     protected static ?string $navigationIcon = 'heroicon-o-inbox';
 
     protected static ?string $navigationGroup = 'Manage';
+    protected static ?int $navigationSort = 100;
 
     protected static ?string $label = 'Inbox';
 

diff --git a/app/Filament/Resources/ItemResource.php b/app/Filament/Resources/ItemResource.php
@@ -33,6 +33,8 @@ class ItemResource extends Resource
 
     protected static ?string $recordTitleAttribute = 'title';
 
+    protected static ?int $navigationSort = 101;
+
     public static function form(Form $form): Form
     {
         $gitHubService = (new GitHubService);

diff --git a/app/Filament/Resources/ProjectResource.php b/app/Filament/Resources/ProjectResource.php
@@ -22,6 +22,8 @@ class ProjectResource extends Resource
 
     protected static ?string $navigationGroup = 'Manage';
 
+    protected static ?int $navigationSort = 103;
+
     public static function form(Form $form): Form
     {
         $gitHubService = (new GitHubService);

diff --git a/app/Filament/Resources/TagResource.php b/app/Filament/Resources/TagResource.php
@@ -21,7 +21,7 @@ class TagResource extends Resource
 
     protected static ?string $navigationGroup = 'Manage';
 
-    protected static ?int $navigationSort = 1;
+    protected static ?int $navigationSort = 106;
 
     public static function form(Form $form): Form
     {

diff --git a/app/Filament/Resources/VoteResource.php b/app/Filament/Resources/VoteResource.php
@@ -18,6 +18,8 @@ class VoteResource extends Resource
 
     protected static ?string $navigationGroup = 'Manage';
 
+    protected static ?int $navigationSort = 105;
+
     public static function form(Form $form): Form
     {
         return $form

diff --git a/app/Services/SystemChecker.php b/app/Services/SystemChecker.php
@@ -4,8 +4,8 @@
 
 class SystemChecker
 {
-    public $remoteVersion;
-    public $currentVersion;
+    public string|null $remoteVersion;
+    public string|null $currentVersion;
 
     public string $cacheKeyCurrent = 'roadmap-current-version';
     public string $cacheKeyRemote = 'roadmap-remote-version';
@@ -18,29 +18,29 @@ public function getVersions(): self
         return $this;
     }
 
-    public function getApplicationVersion()
+    public function getApplicationVersion(): string|null
     {
         return cache()->remember($this->cacheKeyCurrent, now()->addDay(), function () {
             return shell_exec('git describe --tag --abbrev=0');
         });
     }
 
-    public function getRemoteVersion()
+    public function getRemoteVersion(): string|null
     {
         return cache()->remember($this->cacheKeyRemote, now()->addDay(), function () {
             shell_exec('git fetch --tags');
             return shell_exec('git describe --tags $(git rev-list --tags --max-count=1)');
         });
     }
 
-    public function isOutOfDate()
+    public function isOutOfDate(): bool
     {
         $this->getVersions();
 
         return $this->currentVersion < $this->remoteVersion || $this->currentVersion != $this->remoteVersion;
     }
 
-    public function flushVersionData()
+    public function flushVersionData(): void
     {
         try {
             cache()->forget($this->cacheKeyCurrent);