refactor: fix phpstan errors in the providers & CommentObserver

ploi · Nov 10, 2024 · d7e899d · d7e899d
1 parent 32d7207
commit d7e899d
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/app/Observers/CommentObserver.php b/app/Observers/CommentObserver.php
@@ -35,7 +35,7 @@ public function created(Comment $comment): void
             $user->notify(new ItemHasNewCommentNotification($comment, $user));
         });
 
-        $comment->parent?->user->notify(new CommentHasReplyNotification($comment));
+        $comment->parent?->user?->notify(new CommentHasReplyNotification($comment));
     }
 
     public function deleting(Comment $comment): void

diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
@@ -17,7 +17,7 @@ public function boot(Kernel $kernel): void
         View::composer('partials.meta', static function ($view) {
             $view->with(
                 'defaultImage',
-                OgImageGenerator::make(config('app.name'))
+                OgImageGenerator::make(config()->string('app.name'))
                     ->withSubject('Roadmap')
                     ->withPolygonDecoration()
                     ->withFilename('og.jpg')

diff --git a/app/Providers/Filament/AdminPanelProvider.php b/app/Providers/Filament/AdminPanelProvider.php
@@ -36,7 +36,7 @@ public function panel(Panel $panel): Panel
             ->colors([
                 'primary' => Color::Blue,
             ])
-            ->spa(config('filament.spa'))
+            ->spa(config()->boolean('filament.spa'))
             ->viteTheme('resources/css/admin.css')
             ->favicon(file_exists($favIcon = storage_path('app/public/favicon.png')) ? asset('storage/favicon.png') . '?v=' . md5_file($favIcon) : null)
             ->discoverResources(in: app_path('Filament/Resources'), for: 'App\\Filament\\Resources')

diff --git a/app/Providers/HelperServiceProvider.php b/app/Providers/HelperServiceProvider.php
@@ -11,9 +11,9 @@ class HelperServiceProvider extends ServiceProvider
      *
      * @return void
      */
-    public function register()
+    public function register(): void
     {
-        foreach (glob(app_path('Helpers') . '/*.php') as $file) {
+        foreach (glob(app_path('Helpers') . '/*.php') ?: [] as $file) {
             require_once $file;
         }
     }

diff --git a/app/Rules/ProfanityCheck.php b/app/Rules/ProfanityCheck.php
@@ -7,7 +7,12 @@
 
 class ProfanityCheck implements Rule
 {
-    public function passes($attribute, $value)
+    /**
+     * @param $attribute
+     * @param string $value
+     * @return bool
+     */
+    public function passes($attribute, $value): bool
     {
         $words = explode(' ', $value);
 
@@ -20,7 +25,7 @@ public function passes($attribute, $value)
         return true;
     }
 
-    public function message()
+    public function message(): string
     {
         return 'The content here contains profanity words, please correct these.';
     }