Merge pull request #256 from Autive/feature/disable-user-registration

Feature/disable user registration
ploi · Jan 10, 2024 · 4956b2b · 4956b2b
2 parents f064b32 + 8d8013b
commit 4956b2b
Show file tree

Hide file tree

Showing 8 changed files with 60 additions and 16 deletions.
diff --git a/app/Filament/Pages/Settings.php b/app/Filament/Pages/Settings.php
@@ -2,16 +2,14 @@
 
 namespace App\Filament\Pages;
 
-use Filament\Actions\Action;
-use Filament\Notifications\Notification;
-use Filament\Support\Enums\Alignment;
 use Storage;
 use App\Models\Board;
 use App\Enums\UserRole;
 use App\Models\Project;
 use Filament\Forms\Form;
 use Illuminate\Support\Str;
 use App\Enums\InboxWorkflow;
+use Filament\Actions\Action;
 use App\Services\GitHubService;
 use Filament\Pages\SettingsPage;
 use App\Settings\GeneralSettings;
@@ -21,11 +19,13 @@
 use Filament\Forms\Components\Group;
 use Filament\Forms\Components\Select;
 use Filament\Forms\Components\Toggle;
+use Filament\Support\Enums\Alignment;
 use Filament\Forms\Components\Section;
 use Filament\Forms\Components\Repeater;
 use Filament\Forms\Components\Textarea;
 use Filament\Forms\Components\TagsInput;
 use Filament\Forms\Components\TextInput;
+use Filament\Notifications\Notification;
 use Filament\Forms\Components\RichEditor;
 
 class Settings extends SettingsPage
@@ -113,6 +113,10 @@ public function form(Form $form): Form
                                         ->label('Disallow users to upload files or images via the markdown editors.')
                                         ->columnSpan(1),
 
+                                    Toggle::make('disable_user_registration')
+                                        ->label('Disable user registration')
+                                        ->columnSpan(1),
+
                                     Toggle::make('show_github_link')
                                         ->label('Show a link to the linked GitHub issue on the item page')
                                         ->columnSpan(1)

diff --git a/app/Http/Controllers/Auth/RegisterController.php b/app/Http/Controllers/Auth/RegisterController.php
@@ -3,6 +3,7 @@
 namespace App\Http\Controllers\Auth;
 
 use App\Models\User;
+use App\Settings\GeneralSettings;
 use App\Http\Controllers\Controller;
 use App\SocialProviders\SsoProvider;
 use Illuminate\Support\Facades\Hash;
@@ -36,6 +37,10 @@ protected function validator(array $data)
 
     protected function create(array $data)
     {
+        if (app(GeneralSettings::class)->disable_user_registration) {
+            abort(301, 'User registration is disabled.');
+        }
+
         return User::create([
             'name' => $data['name'],
             'email' => $data['email'],
@@ -45,6 +50,10 @@ protected function create(array $data)
 
     public function showRegistrationForm()
     {
+        if (app(GeneralSettings::class)->disable_user_registration) {
+            return redirect()->route('home');
+        }
+
         if (SsoProvider::isForced()) {
             return to_route('oauth.login');
         }

diff --git a/app/Settings/GeneralSettings.php b/app/Settings/GeneralSettings.php
@@ -30,6 +30,7 @@ class GeneralSettings extends Settings
     public bool $show_changelog_author;
     public bool $show_changelog_related_items;
     public bool $disable_file_uploads;
+	public bool $disable_user_registration;
     public array $excluded_matching_search_words;
     public array $profanity_words;
     public bool $show_github_link;

diff --git a/database/settings/2024_01_09_181742_create_disable_user_setting.php b/database/settings/2024_01_09_181742_create_disable_user_setting.php
@@ -0,0 +1,10 @@
+<?php
+
+use Spatie\LaravelSettings\Migrations\SettingsMigration;
+
+return new class extends SettingsMigration {
+    public function up(): void
+    {
+        $this->migrator->add('general.disable_user_registration', false);
+    }
+};
diff --git a/resources/views/livewire/header.blade.php b/resources/views/livewire/header.blade.php
@@ -22,12 +22,14 @@
                             {{ trans('auth.login') }}
                         </a>
                     </li>
-                    <li>
-                        <a class="flex items-center justify-center text-white hover:text-gray-50 focus:outline-none"
-                           href="{{ route('register') }}">
-                            {{ trans('auth.register') }}
-                        </a>
-                    </li>
+                    @if(! app(App\Settings\GeneralSettings::class)->disable_user_registration)
+                        <li>
+                            <a class="flex items-center justify-center text-white hover:text-gray-50 focus:outline-none"
+                               href="{{ route('register') }}">
+                                {{ trans('auth.register') }}
+                            </a>
+                        </li>
+                    @endif
                 @endguest
 
                 @auth

diff --git a/resources/views/partials/header.blade.php b/resources/views/partials/header.blade.php
@@ -22,12 +22,14 @@
                             {{ trans('auth.login') }}
                         </a>
                     </li>
-                    <li>
-                        <a class="flex items-center justify-center text-white hover:text-gray-50 focus:outline-none"
-                           href="{{ route('register') }}">
-                            {{ trans('auth.register') }}
-                        </a>
-                    </li>
+                    @if(! app(App\Settings\GeneralSettings::class)->disable_user_registration)
+                        <li>
+                            <a class="flex items-center justify-center text-white hover:text-gray-50 focus:outline-none"
+                               href="{{ route('register') }}">
+                                {{ trans('auth.register') }}
+                            </a>
+                        </li>
+                    @endif
                 @endguest
 
                 @auth

diff --git a/routes/web.php b/routes/web.php
@@ -1,11 +1,13 @@
 <?php
 
-use App\Http\Controllers\SitemapController;
+use App\Settings\GeneralSettings;
+use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Route;
 use App\Http\Controllers\MyController;
 use App\Http\Controllers\ItemController;
 use App\Http\Controllers\BoardsController;
 use App\Http\Controllers\ProjectController;
+use App\Http\Controllers\SitemapController;
 use App\Http\Controllers\ChangelogController;
 use App\Http\Controllers\Auth\VerificationController;
 use App\Http\Controllers\ItemEmailUnsubscribeController;

diff --git a/tests/Feature/Auth/RegistrationTest.php b/tests/Feature/Auth/RegistrationTest.php
@@ -2,6 +2,8 @@
 
 namespace App\Tests\Feature\Auth;
 
+use App\Settings\GeneralSettings;
+
 test('registration screen can be rendered', function () {
     $response = $this->get(route('register'));
 
@@ -43,3 +45,15 @@
 
     $this->assertAuthenticatedAs($user);
 });
+
+test('guests cannot access /register when this feature is disabled', function () {
+    GeneralSettings::fake([
+        'disable_user_registration' => true
+    ]);
+
+    $response = $this->get(route('register'));
+
+	$response->assertRedirect(route('home'));
+	$response->assertStatus(302);
+});
+