Fix issues reported by golangsci-lint

message/codes/codes.go

@@ -4,6 +4,8 @@ import (
 	"errors"
 	"fmt"
 	"strconv"
+
+	"github.com/plgd-dev/go-coap/v3/pkg/math"
 )
 
 // A Code is an unsigned 16-bit coap code as defined in the coap spec.
@@ -94,14 +96,15 @@ var strToCode = map[string]Code{
 }
 
 func getMaxCodeLen() int {
-	// max uint32 as string binary representation: "0b" + 32 digits
-	max := 34
+	// maxLen uint32 as string binary representation: "0b" + 32 digits
+	maxLen := 34
 	for k := range strToCode {
-		if len(k) > max {
-			max = len(k)
+		kLen := len(k)
+		if kLen > maxLen {
+			maxLen = kLen
 		}
 	}
-	return max
+	return maxLen
 }
 
 func init() {
@@ -128,8 +131,7 @@ func (c *Code) UnmarshalJSON(b []byte) error {
 		if ci >= _maxCode {
 			return fmt.Errorf("invalid code: %q", ci)
 		}
-
-		*c = Code(ci)
+		*c = math.CastTo[Code](ci)
 		return nil
 	}
 

message/encodeDecodeUint32.go

@@ -2,6 +2,8 @@ package message
 
 import (
 	"encoding/binary"
+
+	"github.com/plgd-dev/go-coap/v3/pkg/math"
 )
 
 func EncodeUint32(buf []byte, value uint32) (int, error) {
@@ -18,7 +20,7 @@ func EncodeUint32(buf []byte, value uint32) (int, error) {
 		if len(buf) < 2 {
 			return 2, ErrTooSmall
 		}
-		binary.BigEndian.PutUint16(buf, uint16(value))
+		binary.BigEndian.PutUint16(buf, math.CastTo[uint16](value))
 		return 2, nil
 	case value <= max3ByteNumber:
 		if len(buf) < 3 {

message/getmid.go

@@ -7,6 +7,7 @@ import (
 	"sync/atomic"
 	"time"
 
+	pkgMath "github.com/plgd-dev/go-coap/v3/pkg/math"
 	pkgRand "github.com/plgd-dev/go-coap/v3/pkg/rand"
 )
 
@@ -16,17 +17,17 @@ var msgID = uint32(RandMID())
 
 // GetMID generates a message id for UDP. (0 <= mid <= 65535)
 func GetMID() int32 {
-	return int32(uint16(atomic.AddUint32(&msgID, 1)))
+	return int32(pkgMath.CastTo[uint16](atomic.AddUint32(&msgID, 1)))
 }
 
 func RandMID() int32 {
 	b := make([]byte, 4)
 	_, err := rand.Read(b)
 	if err != nil {
 		// fallback to cryptographically insecure pseudo-random generator
-		return int32(uint16(weakRng.Uint32() >> 16))
+		return int32(pkgMath.CastTo[uint16](weakRng.Uint32() >> 16))
 	}
-	return int32(uint16(binary.BigEndian.Uint32(b)))
+	return int32(pkgMath.CastTo[uint16](binary.BigEndian.Uint32(b)))
 }
 
 // ValidateMID validates a message id for UDP. (0 <= mid <= 65535)

message/option.go

@@ -4,6 +4,9 @@ import (
 	"encoding/binary"
 	"errors"
 	"strconv"
+
+	"github.com/plgd-dev/go-coap/v3/pkg/math"
+	"golang.org/x/exp/constraints"
 )
 
 const (
@@ -236,6 +239,18 @@ func ToMediaType(v string) (MediaType, error) {
 	return 0, errors.New("not found")
 }
 
+func MediaTypeFromNumber[T constraints.Integer](v T) (MediaType, error) {
+	mt, err := math.SafeCastTo[MediaType](v)
+	if err != nil {
+		return MediaType(0), err
+	}
+	_, ok := mediaTypeToString[mt]
+	if !ok {
+		return MediaType(0), errors.New("invalid value")
+	}
+	return mt, nil
+}
+
 func extendOpt(opt int) (int, int) {
 	ext := 0
 	if opt >= ExtendOptionByteAddend {
@@ -269,7 +284,7 @@ func marshalOptionHeaderExt(buf []byte, opt, ext int) (int, error) {
 		return 1, ErrTooSmall
 	case ExtendOptionWordCode:
 		if len(buf) > 1 {
-			binary.BigEndian.PutUint16(buf, uint16(ext))
+			binary.BigEndian.PutUint16(buf, math.CastTo[uint16](ext))
 			return 2, nil
 		}
 		return 2, ErrTooSmall
@@ -435,7 +450,8 @@ func (o *Option) Unmarshal(data []byte, optionDefs map[OptionID]OptionDef, optio
 			// Skip unrecognized options (RFC7252 section 5.4.1)
 			return len(data), nil
 		}
-		if uint32(len(data)) < def.MinLen || uint32(len(data)) > def.MaxLen {
+		dataLen := math.CastTo[uint32](len(data))
+		if dataLen < def.MinLen || dataLen > def.MaxLen {
 			// Skip options with illegal value length (RFC7252 section 5.4.3)
 			return len(data), nil
 		}

message/options.go

@@ -2,7 +2,10 @@ package message
 
 import (
 	"errors"
+	"fmt"
 	"strings"
+
+	"github.com/plgd-dev/go-coap/v3/pkg/math"
 )
 
 // Options Container of COAP Options, It must be always sort'ed after modification.
@@ -207,7 +210,10 @@ func (options Options) GetUint32(id OptionID) (uint32, error) {
 // ContentFormat gets the content format of body.
 func (options Options) ContentFormat() (MediaType, error) {
 	v, err := options.GetUint32(ContentFormat)
-	return MediaType(v), err
+	if err != nil {
+		return MediaType(0), err
+	}
+	return MediaTypeFromNumber(v)
 }
 
 // GetString gets the string value of the first option with the given ID.
@@ -353,7 +359,10 @@ func (options Options) SetAccept(buf []byte, contentFormat MediaType) (Options,
 // Accept gets accept option.
 func (options Options) Accept() (MediaType, error) {
 	v, err := options.GetUint32(Accept)
-	return MediaType(v), err
+	if err != nil {
+		return MediaType(0), err
+	}
+	return MediaTypeFromNumber(v)
 }
 
 // Find returns range of type options. First number is index and second number is index of next option type.
@@ -576,7 +585,10 @@ func (options *Options) Unmarshal(data []byte, optionDefs map[OptionID]OptionDef
 		}
 
 		option := Option{}
-		oid := OptionID(prev + delta)
+		oid, err := math.SafeCastTo[OptionID](prev + delta)
+		if err != nil {
+			return -1, fmt.Errorf("%w: %w", ErrOptionNotFound, err)
+		}
 		proc, err = option.Unmarshal(data[:length], optionDefs, oid)
 		if err != nil {
 			return -1, err

message/pool/message.go

@@ -373,7 +373,10 @@ func (r *Message) AddOptionUint32(opt message.OptionID, value uint32) {
 
 func (r *Message) ContentFormat() (message.MediaType, error) {
 	v, err := r.GetOptionUint32(message.ContentFormat)
-	return message.MediaType(v), err
+	if err != nil {
+		return message.MediaType(0), err
+	}
+	return message.MediaTypeFromNumber(v)
 }
 
 func (r *Message) HasOption(id message.OptionID) bool {
@@ -400,7 +403,10 @@ func (r *Message) SetAccept(contentFormat message.MediaType) {
 // Accept get's accept option.
 func (r *Message) Accept() (message.MediaType, error) {
 	v, err := r.GetOptionUint32(message.Accept)
-	return message.MediaType(v), err
+	if err != nil {
+		return message.MediaType(0), err
+	}
+	return message.MediaTypeFromNumber(v)
 }
 
 func (r *Message) BodySize() (int64, error) {

net/blockwise/blockwise.go

@@ -14,6 +14,7 @@ import (
 	"github.com/plgd-dev/go-coap/v3/message/pool"
 	"github.com/plgd-dev/go-coap/v3/net/responsewriter"
 	"github.com/plgd-dev/go-coap/v3/pkg/cache"
+	"github.com/plgd-dev/go-coap/v3/pkg/math"
 	"golang.org/x/sync/semaphore"
 )
 
@@ -98,13 +99,13 @@ func EncodeBlockOption(szx SZX, blockNumber int64, moreBlocksFollowing bool) (ui
 	if blockNumber > maxBlockNumber {
 		return 0, ErrBlockNumberExceedLimit
 	}
-	blockVal := uint32(blockNumber << 4)
+	blockVal := math.CastTo[uint32](blockNumber << 4)
 	m := uint32(0)
 	if moreBlocksFollowing {
 		m = 1
 	}
 	blockVal += m << 3
-	blockVal += uint32(szx)
+	blockVal += math.CastTo[uint32](szx)
 	return blockVal, nil
 }
 
@@ -238,7 +239,11 @@ func (b *BlockWise[C]) Do(r *pool.Message, maxSzx SZX, maxMessageSize uint32, do
 	}
 	req := b.cloneMessage(r)
 	defer b.cc.ReleaseMessage(req)
-	req.SetOptionUint32(message.Size1, uint32(payloadSize))
+	payloadSizeUint32, err := math.SafeCastTo[uint32](payloadSize)
+	if err != nil {
+		return nil, fmt.Errorf("cannot set payload size: %w", err)
+	}
+	req.SetOptionUint32(message.Size1, payloadSizeUint32)
 	block, err := EncodeBlockOption(maxSzx, 0, true)
 	if err != nil {
 		return nil, fmt.Errorf("cannot encode block option(%v, %v, %v) to bw request: %w", maxSzx, 0, true, err)
@@ -436,9 +441,7 @@ func (b *BlockWise[C]) createSendingMessage(sendingMessage *pool.Message, maxSZX
 		b.cc.ReleaseMessage(sendMessage)
 		return nil, false, payloadSizeError(err)
 	}
-	if szx > maxSZX {
-		szx = maxSZX
-	}
+	szx = getSzx(szx, maxSZX)
 	newBufLen := bufferSize(szx, maxMessageSize)
 	off := num * szx.Size()
 	if blockType == message.Block1 {
@@ -471,13 +474,19 @@ func (b *BlockWise[C]) createSendingMessage(sendingMessage *pool.Message, maxSZX
 		return nil, false, fmt.Errorf("cannot read response: %w", err)
 	}
 
+	payloadSizeUint32, err := math.SafeCastTo[uint32](payloadSize)
+	if err != nil {
+		b.cc.ReleaseMessage(sendMessage)
+		return nil, false, fmt.Errorf("cannot set payload size: %w", err)
+	}
+	sendMessage.SetOptionUint32(sizeType, payloadSizeUint32)
+
 	buf = buf[:readed]
 	sendMessage.SetBody(bytes.NewReader(buf))
 	more = true
 	if offSeek+int64(readed) == payloadSize {
 		more = false
 	}
-	sendMessage.SetOptionUint32(sizeType, uint32(payloadSize))
 	num = (offSeek) / szx.Size()
 	block, err = EncodeBlockOption(szx, num, more)
 	if err != nil {

pkg/math/cast.go

@@ -0,0 +1,55 @@
+package math
+
+import (
+	"fmt"
+	"log"
+	"unsafe"
+
+	"golang.org/x/exp/constraints"
+)
+
+func Max[T constraints.Integer]() T {
+	size := unsafe.Sizeof(T(0))
+	switch any(T(0)).(type) {
+	case int, int8, int16, int32, int64:
+		return T(1<<(size*8-1) - 1) // 2^(n-1) - 1 for signed integers
+	case uint, uint8, uint16, uint32, uint64:
+		return T(1<<(size*8) - 1) // 2^n - 1 for unsigned integers
+	default:
+		panic("unsupported type")
+	}
+}
+
+func Min[T constraints.Integer]() T {
+	size := unsafe.Sizeof(T(0))
+	switch any(T(0)).(type) {
+	case int, int8, int16, int32, int64:
+		return T(int64(-1) << (size*8 - 1)) // -2^(n-1)
+	case uint, uint8, uint16, uint32, uint64:
+		return T(0)
+	default:
+		panic("unsupported type")
+	}
+}
+
+func SafeCastTo[T, F constraints.Integer](from F) (T, error) {
+	if from > 0 && uint64(Max[T]()) < uint64(from) {
+		return T(0), fmt.Errorf("value(%v) exceeds the maximum value for type(%v)", from, Max[T]())
+	}
+	if from < 0 && int64(Min[T]()) > int64(from) {
+		return T(0), fmt.Errorf("value(%v) exceeds the minimum value for type(%v)", from, Min[T]())
+	}
+	return T(from), nil
+}
+
+func CastTo[T, F constraints.Integer](from F) T {
+	return T(from)
+}
+
+func MustSafeCastTo[T, F constraints.Integer](from F) T {
+	to, err := SafeCastTo[T](from)
+	if err != nil {
+		log.Panicf("value (%v) out of bounds for type %T", from, T(0))
+	}
+	return to
+}