Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement OCF bridge device #421

Merged

Conversation

Danielius1922
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (4ece331) 67.24% compared to head (4869367) 61.41%.

Files Patch % Lines
test/client/client.go 54.80% 37 Missing and 10 partials ⚠️
bridge/device/cloud/manager.go 0.00% 11 Missing ⚠️
bridge/test/test.go 92.10% 2 Missing and 1 partial ⚠️
bridge/resources/resource.go 50.00% 1 Missing and 1 partial ⚠️
bridge/service/service.go 0.00% 2 Missing ⚠️
bridge/net/network.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           jkralik/feature/bridge-device     #421      +/-   ##
=================================================================
- Coverage                          67.24%   61.41%   -5.84%     
=================================================================
  Files                                 80       92      +12     
  Lines                               5514     6977    +1463     
=================================================================
+ Hits                                3708     4285     +577     
- Misses                              1388     2213     +825     
- Partials                             418      479      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Danielius1922 Danielius1922 force-pushed the adam/feature/bridge-device branch 8 times, most recently from 318337f to bef90fe Compare January 19, 2024 14:00
@Danielius1922 Danielius1922 changed the base branch from main to jkralik/feature/bridge-device January 19, 2024 14:01
@Danielius1922 Danielius1922 marked this pull request as ready for review January 19, 2024 14:04
@Danielius1922 Danielius1922 requested a review from jkralik January 19, 2024 14:04
@Danielius1922 Danielius1922 force-pushed the adam/feature/bridge-device branch from bef90fe to 2b14143 Compare January 19, 2024 14:28
@Danielius1922 Danielius1922 force-pushed the jkralik/feature/bridge-device branch from a63d60b to 4ece331 Compare January 19, 2024 14:31
@Danielius1922 Danielius1922 force-pushed the adam/feature/bridge-device branch from 2b14143 to 4869367 Compare January 19, 2024 14:33
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

35.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

@Danielius1922 Danielius1922 merged commit 7299a45 into jkralik/feature/bridge-device Jan 19, 2024
9 of 10 checks passed
@Danielius1922 Danielius1922 deleted the adam/feature/bridge-device branch January 19, 2024 14:41
jkralik pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants