-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bridge-device functionality for onboarding non-OCF compliant devices #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielius1922
force-pushed
the
jkralik/feature/bridge-device
branch
from
January 19, 2024 14:31
a63d60b
to
4ece331
Compare
- unsecure for D2D, ipv4
propagate URIquery option eg
- tests for sign up, sing in, sign off, publish resources and refresh token
Go test runs tests from different packages in different binaries and these run in parallel. It's possible that the test bridge service in different tests execute at the same time, which would cause failures ("bind address already in use") if the port was not random.
jkralik
force-pushed
the
jkralik/feature/bridge-device
branch
from
February 1, 2024 14:58
7fa196d
to
f117737
Compare
jkralik
force-pushed
the
jkralik/feature/bridge-device
branch
from
February 2, 2024 07:46
f1a6368
to
9e994f5
Compare
jkralik
changed the title
Jkralik/feature/bridge device
Implement bridge-device functionality for onboarding non-OCF compliant devices
Feb 3, 2024
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
DEVSIM_NET_HOST_PATH = $(shell pwd)/.tmp/devsim-net-host | ||
CERT_TOOL_IMAGE ?= ghcr.io/plgd-dev/hub/cert-tool:vnext | ||
# supported values: ECDSA-SHA256, ECDSA-SHA384, ECDSA-SHA512 | ||
CERT_TOOL_SIGN_ALG ?= ECDSA-SHA256 | ||
# supported values: P256, P384, P521 | ||
CERT_TOOL_ELLIPTIC_CURVE ?= P256 | ||
DEVSIM_IMAGE ?= ghcr.io/iotivity/iotivity-lite/cloud-server-discovery-resource-observable-debug:vnext | ||
HUB_TEST_DEVICE_IMAGE = ghcr.io/plgd-dev/hub/test-cloud-server:vnext-pr1202 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: update to vnext after
Danielius1922
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a bridge-device service facilitating access to bridged devices, incorporating extensions beyond the OCF specification for local access. Notable distinctions include the use of a single opened UDP (potentially DTLS in the future) for Plgd bridged devices, contrasting with OCF bridged devices that utilize individual UDP/DTLS/TCP/TCP-TLS for both IPv4 and IPv6.
Key Points:
di=<deviceID>
in the request./oic/res
) without thedi
parameter provides links for all devices. Each link contains a deviceID, specifying the required value for thedi
query parameter.di
parameter results in failure.Features:
To Be Implemented:
NOTE
The bridge-device is compatible with client-application 0.10.0 or later.