Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't process body when update/get return code valid #413

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

lubo-svk
Copy link
Collaborator

@lubo-svk lubo-svk commented Dec 8, 2023

No description provided.

@lubo-svk lubo-svk requested a review from jkralik December 8, 2023 09:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3200d43) 67.07% compared to head (e50054a) 67.04%.

Files Patch % Lines
pkg/net/coap/client.go 14.28% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   67.07%   67.04%   -0.04%     
==========================================
  Files          80       80              
  Lines        5492     5496       +4     
==========================================
+ Hits         3684     3685       +1     
- Misses       1392     1394       +2     
- Partials      416      417       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkralik jkralik force-pushed the lubo_svk/fix/dont-decode-empty-body branch from 2e194a1 to e50054a Compare December 8, 2023 13:08
Copy link

sonarqubecloud bot commented Dec 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jkralik jkralik merged commit 70c0615 into main Dec 8, 2023
9 of 10 checks passed
@jkralik jkralik deleted the lubo_svk/fix/dont-decode-empty-body branch December 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants