Add Ghcr clean-up workflow

.github/workflows/ghcr-cleanup.yaml

@@ -0,0 +1,46 @@
+name: Delete old ghcr images
+on:
+  schedule:
+    - cron: "15 1 * * *" # every day at 1:15am
+  pull_request:
+    types: [closed]
+  workflow_dispatch:
+
+jobs:
+  pull-request-ghcr-cleanup:
+    if: ${{ github.event_name == 'pull_request' }}
+    name: Delete images related to closed PR
+    runs-on: ubuntu-latest
+    steps:
+      - name: Delete images related to closed PR
+        uses: snok/container-retention-policy@v2
+        with:
+          image-names: device/*
+          cut-off: now UTC
+          account-type: org
+          org-name: plgd-dev
+          filter-tags: vnext-pr${{ github.event.pull_request.number }}*
+          token: ${{ secrets.GHCR_CLEANUP_PAT }}
+
+  nightly-ghcr-cleanup:
+    if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
+    name: Delete old vnext images
+    runs-on: ubuntu-latest
+    steps:
+      - name: Delete older than a month vnext images
+        uses: snok/container-retention-policy@v2
+        with:
+          image-names: device/*
+          cut-off: One month ago UTC
+          account-type: org
+          org-name: plgd-dev
+          filter-tags: vnext-*
+          skip-tags: vnext-pr*, main
+          token: ${{ secrets.GHCR_CLEANUP_PAT }}
+
+      - name: Delete untagged images with no dependency
+        uses: Chizkiyahu/delete-untagged-ghcr-action@v3
+        with:
+          token: ${{ secrets.GHCR_CLEANUP_PAT }}
+          owner_type: org
+          except_untagged_multiplatform: true          

.golangci.yml

@@ -10,11 +10,11 @@ linters-settings:
       modules:
         - github.com/pkg/errors:
             recommendations:
-            - errors
+              - errors
   stylecheck:
     # STxxxx checks in https://staticcheck.io/docs/configuration/options/#checks
     # Default: ["*"]
-    checks: [ "all", "-ST1000", "-ST1003" ]
+    checks: ["all", "-ST1000", "-ST1003"]
 
 linters:
   enable:
@@ -116,6 +116,7 @@ issues:
     - path: cmd/ocfclient/main\.go
       linters:
         - gocognit
+        - goconst
         - gocyclo
         - gosec
 

client/updateResource_test.go

@@ -200,7 +200,7 @@ func TestClientUpdateResourceInRFOTM(t *testing.T) {
 				deviceID: deviceID,
 				href:     configuration.ResourceURI,
 				data: map[string]interface{}{
-					"n": t.Name() + "-valid",
+					"n": t.Name() + "-forbidden",
 				},
 				opts: []client.UpdateOption{client.WithDiscoveryConfiguration(core.DefaultDiscoveryConfiguration())},
 			},