Refactor default member initialization for those that are required - …

…m_invert was lacking before.
plerup · Apr 21, 2023 · 7c9f467 · 7c9f467
1 parent c0dc6d6
commit 7c9f467
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/src/SoftwareSerial.cpp b/src/SoftwareSerial.cpp
@@ -52,18 +52,10 @@ __attribute__((always_inline)) inline void IRAM_ATTR UARTBase::restoreInterrupts
 constexpr uint8_t BYTE_ALL_BITS_SET = ~static_cast<uint8_t>(0);
 
 UARTBase::UARTBase() {
-    m_isrOverflow = false;
-    m_rxGPIOHasPullUp = false;
-    m_rxGPIOPullUpEnabled = true;
-    m_txGPIOOpenDrain = false;
 }
 
 UARTBase::UARTBase(int8_t rxPin, int8_t txPin, bool invert)
 {
-    m_isrOverflow = false;
-    m_rxGPIOHasPullUp = false;
-    m_rxGPIOPullUpEnabled = true;
-    m_txGPIOOpenDrain = false;
     m_rxPin = rxPin;
     m_txPin = txPin;
     m_invert = invert;

diff --git a/src/SoftwareSerial.h b/src/SoftwareSerial.h
@@ -342,9 +342,9 @@ class UARTBase : public Stream {
     /// PDU bits include data, parity and stop bits; the start bit is not counted.
     uint8_t m_pduBits;
     bool m_intTxEnabled;
-    bool m_rxGPIOHasPullUp;
-    bool m_rxGPIOPullUpEnabled;
-    bool m_txGPIOOpenDrain;
+    bool m_rxGPIOHasPullUp = false;
+    bool m_rxGPIOPullUpEnabled = true;
+    bool m_txGPIOOpenDrain = false;
     Parity m_parityMode;
     uint8_t m_stopBits;
     bool m_lastReadParity;
@@ -367,7 +367,7 @@ class UARTBase : public Stream {
     // 1 = positive including 0, 0 = negative.
     std::unique_ptr<circular_queue<uint32_t, UARTBase*> > m_isrBuffer;
     const Delegate<void(uint32_t&&), UARTBase*> m_isrBufferForEachDel = { [](UARTBase* self, uint32_t&& isrTick) { self->rxBits(isrTick); }, this };
-    std::atomic<bool> m_isrOverflow;
+    std::atomic<bool> m_isrOverflow = false;
     uint32_t m_isrLastTick;
     bool m_rxCurParity = false;
     Delegate<void(), void*> m_rxHandler;