Support >22 args in Scala 3 #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
force-pushed
the
rm-Template0-22
branch
3 times, most recently
from
5c30b9a to
e21b3d0
Compare
|
Fix was quite easy and we can even ship it in a patch release. |
|
@Mergifyio backport 1.6.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fixFixesThis is WIP.If this works
theTemplate.scalashould be moved into ascala-2.13(alsoscala-2.12?) folder andScalaCompatscparameter to decide wheter we need to add... with _root_.play.twirl.api.TemplateX[...]or not to stay compatible with Scala 2.13.Also MiMa filters need to be adjusted.