Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Camera Frame script and integrate SSAO settings #131

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

marklundin
Copy link
Member

Adds the CameraFrame.mjs script to the scripts dir and instantiates in the physics cluster demo.

@marklundin marklundin self-assigned this Feb 12, 2025
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! But I'm a little confused why this now works for you since this PR is basically what I tried before... 🤔 Anyway, thanks! 🙌

@willeastcott willeastcott merged commit a1e94a6 into main Feb 12, 2025
2 checks passed
@willeastcott willeastcott deleted the feat-adding-ssao branch February 12, 2025 14:32
@marklundin
Copy link
Member Author

Not sure, but I noticed that you have to specifiy the other sub attributes, otherwise it will just get overwritten

ssao: {
   "type": "combine",
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants