Try to make ingest lock timeout tests less flaky #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
approved these changes
Sep 26, 2024
|
@aerosol hmmm, I could track whether there's con_cache lock present with "eventually" in tight loop and only attempt the second ingest after that's satisfied. I'll see how feasible that is. |
|
doesn't have to be con_cache specifically, since we're preloading the module in test_helper now |
|
What I did to track it down previously:
|
zoldar
force-pushed
the
fix-flaky-ingest-lock-test
branch
from
36272ad
to
d625e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Can't tell for sure as this test fail is hard to reproduce, but I suspect there might be situations where reaching session processing step in the first ingest takes longer than the sleep before spinning up the second ingest.