Channel and source data updates #4599
Open
+1,067
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukutaht
commented
Sep 19, 2024
| defmodule Plausible.IngestRepo.Migrations.RemapSources do | ||
| use Ecto.Migration | ||
|
|
||
| @mappings %{ |
There was a problem hiding this comment.
I could have used the @custom_sources and @mappings_overrides module attributes here, but decided to duplicate the list in case it changes in the future. Don't want migrations to reference dynamic code in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some adjustments on how we handle and categorize source/channel data based on manual testing by @metmarkosaric.
Largely this includes 2 kinds of changes:
perplexity.aitoPerplexity). These also include a migration to apply these changes to historical dataTelegramshould beSocialinstead ofReferral). These will only apply going forward. Dealing with historical and already collected channel data is not in scope of this PR. Since channels are not live to customers yet it's ok to have them in a slightly broken state for a while. A follow-up PR will deal with historical channel data.Another change is that I've introduced
SOURCE_CATEGORY_EMAILwhich is not present in the GA4 channel grouping definitions. The goal is that sessions with source=Gmail will have channel=email rather than channel=referral.Most of the changes are tests.
Tests
Documentation
Dark mode