Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joystick control cuts out #70

Open
shawnhanna opened this issue Jun 13, 2017 · 7 comments
Open

Joystick control cuts out #70

shawnhanna opened this issue Jun 13, 2017 · 7 comments

Comments

@shawnhanna
Copy link

Joystick control, even when we are standing near the robot, often will cut out.

It appears to be worst when running w/o moving your fingers at all (i.e. not updating the throttle values, I assume?)

@shawnhanna
Copy link
Author

I haven't yet tried playing too much with the update rate option. Maybe it needs to be set lower

@jjblum
Copy link
Contributor

jjblum commented Jun 13, 2017

I'm not sure about outside of my branches, but this is a "feature" in the phone server, not the tablet. It isn't cutting out. Any time you press the joystick, the function that runs on the phone server in response starts a "time out" of sorts. If the phone does not receive new joystick inputs, it sets the signals to zero. This prevents a runaway condition.

I think Chris removed this some time ago in a cleanup branch, but I never incorporated that change into my branches.

@shantanu-vyas
Copy link
Contributor

shantanu-vyas commented Jun 15, 2017

If the phone does not receive new joystick inputs, it sets the signals to zero

Maybe I'm misunderstanding this but the tablet joystick is constantly sending out values when the joystick is not at origin. So shouldn't the phone constantly be getting twist values so it doesnt time out?

@shantanu-vyas
Copy link
Contributor

shantanu-vyas commented Jun 15, 2017

Oh I'm wrong.
https://github.com/platypusllc/tablet/blob/master/app/src/main/java/com/platypus/android/tablet/TeleOpPanel.java#L865
Only when its moved does it update the thrust and rudder. We should should switch to a joystick listener to uses the MotionEvent.ACTION_DOWN instead of ACTION_MOVE so it constantly runs while youre holding the joystick.

@christomaszewski
Copy link
Member

christomaszewski commented Jun 15, 2017 via email

@shantanu-vyas
Copy link
Contributor

A commit for the tablet or server?

@christomaszewski
Copy link
Member

christomaszewski commented Jun 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants