implemented CMS entry copy features #130

hyunnbunt · 2025-01-20T07:11:27Z

Created 'Copy Entry' menu item.

When a user �mouses over 'Copy Entry',

when the entry is published, a tooltip appears with 'Creates an unpublished copy with the published data'.
when the entry is unpublished, a tooltip appears with 'Creates a copy with draft data'.

When a user clicks 'Copy Entry', they see a prompt that asks for the new copy's title.
The default value of the input is

when the original entry has no title, ''.
when the original entry has a title, 'Copy of [title of original entry]'.
They can copy without a title.

When a user clicks 'Copy' in a prompt, prompt disappears and they see a message 'Copying...',
and after copy is completed, they see a message 'Copied'.
As the message disappears, the new copy is selected in the entry list.

vercel · 2025-01-20T07:11:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plasmic-cms-i18n	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 25, 2025 8:31am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
react-email-demo	⬜️ Ignored (Inspect)			Jan 25, 2025 8:31am

jaslong · 2025-01-21T18:01:10Z

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

@@ -39,6 +39,10 @@ import { isEqual, isNil, mapValues, pickBy } from "lodash";
 import * as React from "react";
 import { Prompt, Route, useHistory, useRouteMatch } from "react-router";
 import { useBeforeUnload, useInterval } from "react-use";
+import { Modal } from "../widgets/Modal";


Did you set up the pre-commit? It would have automatically formatted imports like this to @/wab/client/widgets/...

jaslong · 2025-01-21T18:05:04Z

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

+                <Menu.Item 
+                  key="copy"
+                  onClick={() => {
+                    if (row.identifier && row.identifier !== "") {


You can simplify this if condition to if (row.identifier)

jaslong · 2025-01-21T18:06:51Z

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

+                    hasUnpublishedChanges
+                      ? "Creates a copy with draft data"
+                      : "Creates an unpublished copy with the published data"


Since we will be showing a modal, I think we can explain how the operation works in the modal instead of in a tooltip which is less discoverable. So you can remove this tooltip.

jaslong · 2025-01-21T18:11:41Z

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

+                  content: "Copying...",
+                  duration: 1,
+                })
+                await mutateRow();


What is this mutateRow for?

jaslong · 2025-01-21T18:13:16Z

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

+            <Button
+              type="primary"
+              onClick={async () => {
+                setShowCopyModal(false)


I think the modal should stay open until the copyCmsRow call finishes. While the network request is still processing, disable the form/button. When the network request finishes, show the success notification and redirect to the new CMS entry's URL.

jaslong · 2025-01-21T18:35:11Z

platform/wab/src/wab/server/db/DbMgr.ts

+    const opts = {
+      identifier: identifier,
+      data: null,
+      draftData: row.draftData ? row.draftData : row.data,


This can be simplified to row.draftData || row.data

jaslong · 2025-01-21T18:35:51Z

platform/wab/src/wab/server/db/DbMgr.ts

+    // If the original row is being published or had been published before,
+    // make the copy unpublished or remove the recent published history.


Not sure this comment makes sense, can you remove or edit it?

jaslong · 2025-01-21T18:37:37Z

platform/wab/src/wab/server/db/DbMgr.ts

+    if (!this.isUserIdSelf(comment.createdById ?? undefined)) {
+      if ("body" in data) {
+        throw new ForbiddenError("Can only do this for self.");
+      }
+      await this.checkProjectPerms(
+        comment.projectId,
+        "content",
+        "resolve a comment",
+        true
+      );
+    }


This seems like a bad merge

jaslong · 2025-01-21T18:40:24Z

platform/wab/src/wab/shared/SharedApi.ts

@@ -1724,6 +1724,16 @@ export abstract class SharedApi {
    return (await this.put(`/cmse/rows/${rowId}`, opts)) as ApiCmseRow;
  }

+  async copyCmsRow(rowId: CmsRowId, copyRowIdentifier: string) {


I would copy the updateCmsRow and use an opts: { identifier: string } argument instead. That way, it's easier to read what the argument is, since the called is required to write identifier: <something>. Also, it's easier to add new arguments in the future.

You would also be able to skip the if check below and just pass in opts directly to post.

jaslong · 2025-01-21T18:41:43Z

platform/live-frame/yarn.lock

This change should not have changed any yarn.lock files. Please revert those.

IcaroG · 2025-01-24T12:50:43Z

platform/wab/src/wab/server/AppServer.ts

-  // runs every 10 minutes
-  cron.schedule("*/10 * * * *", async () => {
-    await sendCommentsNotificationEmails(config);
-  });
-


Also here, some bad merge

removed copy API inside addCmsPublicRoutes removed copy API inside addCmsPublicRoutes 'Set title' warning when asked to copy an entry without identifier modal after copy menu clicked, input for new title API connected, front-back, now user input title is used for the new entry removed warning when no identifier prompt default value changed, back api identifier type fixed to the right value(null) new copy is selected after created input selection code removed removed unnecessary comments Modal import fix Changes after code review, for <Menu.Item> button clicked and disabled, success message after network request, small changes in DbMgr.ts copyCmsRow parameter wrapped in 'opts' object backend server - request parameter changes revert yarn.lock file changes revert platform/live-frame/yarn.lock file changes Modal content, message content changed

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

jaslong · 2025-01-25T05:58:43Z

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

+                >
+                  <span>Copy entry</span>
+                </Menu.Item>
+                <Menu.Divider />


Remove divider

Co-authored-by: Jason Long <j@jaslong.com>

jaslong · 2025-01-29T21:39:31Z

This was merged in 7e86bbf

Thank you!

vercel bot deployed to Preview – plasmic-cms-i18n January 20, 2025 07:12 View deployment

jaslong reviewed Jan 21, 2025

View reviewed changes

vercel bot deployed to Preview – plasmic-cms-i18n January 24, 2025 07:27 View deployment

vercel bot deployed to Preview – plasmic-cms-i18n January 24, 2025 12:38 View deployment

IcaroG requested changes Jan 24, 2025

View reviewed changes

vercel bot deployed to Preview – plasmic-cms-i18n January 24, 2025 12:52 View deployment

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 04:25 View deployment

hyunnbunt force-pushed the impl-COPY branch from 71c5b63 to ca8bde2 Compare January 25, 2025 05:13

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 05:14 View deployment

hyunnbunt force-pushed the impl-COPY branch from ca8bde2 to 7c32b7a Compare January 25, 2025 05:20

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 05:21 View deployment

hyunnbunt force-pushed the impl-COPY branch from 7c32b7a to 39f2a2c Compare January 25, 2025 05:24

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 05:24 View deployment

jaslong reviewed Jan 25, 2025

View reviewed changes

platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx Outdated Show resolved Hide resolved

Removed unnecessary comments

bd1988d

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 05:29 View deployment

identifier type changes

5feb06a

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 05:53 View deployment

jaslong reviewed Jan 25, 2025

View reviewed changes

Copy -> Duplicate, identifier variable fix

8b72336

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 06:14 View deployment

hyunnbunt and others added 2 commits January 25, 2025 17:16

removed menu divider

ab097c9

Update platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx

557b15d

Co-authored-by: Jason Long <j@jaslong.com>

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 08:18 View deployment

merged

7337f1d

vercel bot deployed to Preview – plasmic-cms-i18n January 25, 2025 08:31 View deployment

jaslong closed this Jan 29, 2025

github-actions bot locked and limited conversation to collaborators Jan 29, 2025

hyunnbunt deleted the impl-COPY branch February 1, 2025 07:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implemented CMS entry copy features #130

implemented CMS entry copy features #130

hyunnbunt commented Jan 20, 2025

vercel bot commented Jan 20, 2025 •

edited

Loading

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

jaslong Jan 21, 2025

IcaroG Jan 24, 2025

jaslong Jan 25, 2025

jaslong commented Jan 29, 2025

		// If the original row is being published or had been published before,
		// make the copy unpublished or remove the recent published history.

implemented CMS entry copy features #130

implemented CMS entry copy features #130

Conversation

hyunnbunt commented Jan 20, 2025

vercel bot commented Jan 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaslong commented Jan 29, 2025

vercel bot commented Jan 20, 2025 •

edited

Loading