Merge Germinate update #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataset-graph.hbs : add prefix this. required after frontend framework upgrade #370. api-server-germinate.js : viewDatasetP() : Results of createRecord() are Ember Data record objects, not promises. factor code into functions linkageGroup2block(), createDataset(), blocksFinish(), shareDataset(), to enable order of creation to be changed : create dataset before blocks. Tried adding datasetId to blockAttributes, but got Uncaught Error: Assertion Failed ... is not a record instantiated by @ember-data/store, although the record was added to the (germinate) store OK, checked with store.peekRecord(dataset, dataset.id). block-adj.js : taskGetPaths() : handle undefined .lastPerformed, seen during germinate debugging (may have been caused by breakpoint causing delays).
manage-genotype.js : datasetStoreSampleNames() : use contentOf() to avoid setting .sampleNames on a proxy of dataset. vcfGenotypeSamplesDataset() : add comment that datasetStoreSampleNames() is duplicated for BrAPI, and currently it will try trim().split() on the array t. vcfGenotypeSamples() : wrap vcfGenotypeSamplesDataset() call with promiseThrottle(). headerTextP() : if isGerminate short-cut the vcfGenotypeLookup() request below because Germinate is taking ~1min for it, and there is no benefit - the header is expected to be simply samples. paths-progressive.js : vcfGenotypeLookup() : add Germinate to the BrAPI case (may have had BrAPI tag on Germinate datasets earlier). promises.js : add promiseThrottle().
axis-1d.js : buttonStateEffect() : fix check on .isDestroying, added in aa8a3ce. manage-genotype.hbs : button vcfGenotypeLookup : disabled : convert {{or (and (not ...))}} expression to vcfGenotypeLookupButtonDisabled(). The same change will apply to the other copy of this button; this allows testing both the disabled function and the . manage-genotype.js : add vcfGenotypeLookupButtonDisabled(), replacing hbs boolean expression, enabling addition of check on .vcfGenotypeLookupTask.isRunning. rename vcfGenotypeLookup() to vcfGenotypeLookupP() and wrap with added vcfGenotypeLookup() and vcfGenotypeLookupTask; this enables disabling vcfGenotypeLookup when the task is running. return promise from : vcfGenotypeLookupSelected(), vcfGenotypeLookupAllDatasets(), vcfGenotypeLookupGroup(), to enable disabling vcfGenotypeLookup until the promise completes. domElements.js : eltClassName() : also map : to _, because of Germinate feature id e.g. chr1A:1030304 in dataset 090222, causing error : circle#fc_12_1_12_chr1A:1030304 is not a valid selector. axis.js : axisFeatureCircles_eltId() : apply eltClassName() to feature.id - to handle Germinate features with chr:position as commented on previous line of commit message. ember-cli-build.js : babel : draft require of ember-concurrency/async-arrow-task-transform which will be required for ember-concurrency v4. package.json : ember-concurrency : 4.0.0 -> 3.1.1 because some dependencies (ember-bootstrap, ember-power-select) are using ember-concurrency@3.1.1, and ember-concurrency error : ... the async arrow task function you've provided is not being properly compiled by Babel. ... 4. Ensure that there is only one version of ember-concurrency v2.3.0+ being used in your project (including nested dependencies). vectra-search.js : connectOpenAIApi() : in log, prefix slice with ...
…cy v4 to 3 package-lock.json : ember-concurrency : 4.0.0 -> 3.1.1, to be consistent with nested dependencies, as commented in previous commit @plantinformatics/vcf-genotype-brapi : 1.0.4 -> 1.0.7
{,frontend/}package.json : version : 3.1.0 -> 3.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the completion of Germinate update #423, which contains these sub-issues :
Development branch : feature/reconnectGerminate